fuweng11 commented on code in PR #11758:
URL: https://github.com/apache/inlong/pull/11758#discussion_r1955459874
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -648,9 +649,10 @@ public InlongGroupInfo doDeleteCheck(String groupId,
String operator) {
String.format("current group status=%s was not allowed to
delete", curState));
}
- // If the status not allowed deleting directly, you need to delete the
related "inlong_stream" first,
+ // If the status not allowed deleting directly, and the group mode is
STANDARD,
+ // you need to delete the related "inlong_stream" first.
// otherwise, all associated info will be logically deleted.
- if (GroupStatus.deleteStreamFirst(curState)) {
+ if (GroupStatus.deleteStreamFirst(curState) &&
groupInfo.getInlongGroupMode() == GroupMode.STANDARD.getCode()) {
Review Comment:
```suggestion
if (GroupStatus.deleteStreamFirst(curState) &&
InlongConstants.STANDARD_MODE.equals(groupInfo.getInlongGroupMode())) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
