doleyzi commented on code in PR #12017:
URL: https://github.com/apache/inlong/pull/12017#discussion_r2425112279
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-python/build.sh:
##########
@@ -107,35 +122,29 @@ mkdir "$PY_SDK_DIR/build" && cd "$PY_SDK_DIR/build"
cmake "$PY_SDK_DIR"
make -j 4
Review Comment:
Ditto
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-python/build.sh:
##########
@@ -73,7 +88,7 @@ if [ ! -d "$PY_SDK_DIR/pybind11/build" ]; then
trap 'echo "Error occurred during pybind11 build. Deleting pybind11
folder..."; cd $PY_SDK_DIR; rm -r pybind11; exit 1' ERR
cmake "$PY_SDK_DIR/pybind11"
- cmake --build "$PY_SDK_DIR/pybind11/build" --config Release --target check
+ cmake --build "$PY_SDK_DIR/pybind11/build" --config Release
make -j 4
Review Comment:
It is not recommended to set the compilation parallelism to 4. It is
recommended to set it according to the number of CPU cores of the machine by
using make -j$(nproc) or providing configurable parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
