[iotdb] branch ml_add_peer updated: add logs for buildSyncLogChannel

[xingtanzjr]

This is an automated email from the ASF dual-hosted git repository.

xingtanzjr pushed a commit to branch ml_add_peer
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/ml_add_peer by this push:
     new 797f5175c4 add logs for buildSyncLogChannel
797f5175c4 is described below

commit 797f5175c4b5c70fb616d93c44871434ecca7c5d
Author: Jinrui.Zhang <xingtan...@gmail.com>
AuthorDate: Mon Sep 5 10:11:41 2022 +0800

    add logs for buildSyncLogChannel
---
 .../multileader/MultiLeaderServerImpl.java         | 31 +++++++++++++---------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git 
a/consensus/src/main/java/org/apache/iotdb/consensus/multileader/MultiLeaderServerImpl.java
 
b/consensus/src/main/java/org/apache/iotdb/consensus/multileader/MultiLeaderServerImpl.java
index 197a9f29de..72dec83fc7 100644
--- 
a/consensus/src/main/java/org/apache/iotdb/consensus/multileader/MultiLeaderServerImpl.java
+++ 
b/consensus/src/main/java/org/apache/iotdb/consensus/multileader/MultiLeaderServerImpl.java
@@ -333,7 +333,12 @@ public class MultiLeaderServerImpl {
     // The configuration will be modified during iterating because we will add 
the targetPeer to
     // configuration
     List<Peer> currentMembers = new ArrayList<>(this.configuration);
+    logger.info(
+        "notify current peers to build sync log. group member: {}, target: {}",
+        currentMembers,
+        targetPeer);
     for (Peer peer : currentMembers) {
+      logger.info("build sync log channel from {}", peer);
       if (peer.equals(thisNode)) {
         // use searchIndex for thisNode as the initialSyncIndex because 
targetPeer will load the
         // snapshot produced by thisNode
@@ -400,22 +405,25 @@ public class MultiLeaderServerImpl {
   public void buildSyncLogChannel(Peer targetPeer, long initialSyncIndex)
       throws ConsensusGroupAddPeerException {
     // step 1, build sync channel in LogDispatcher
+    logger.info(
+        "start to build sync log channel to {} with initialSyncIndex {}",
+        targetPeer,
+        initialSyncIndex);
     logDispatcher.addLogDispatcherThread(targetPeer, initialSyncIndex);
+    logger.info(
+        "[complete] add LogDispatcherThread to {} with initialSyncIndex {}",
+        targetPeer,
+        initialSyncIndex);
     // step 2, update configuration
     configuration.add(targetPeer);
-    if (!persistConfigurationUpdate()) {
-      throw new ConsensusGroupAddPeerException(
-          String.format("error when build sync log channel to %s", 
targetPeer));
-    }
+    persistConfigurationUpdate();
+    logger.info("[complete] persist new configuration: {}", configuration);
   }
 
   public void removeSyncLogChannel(Peer targetPeer) throws 
ConsensusGroupAddPeerException {
     logDispatcher.removeLogDispatcherThread(targetPeer);
     configuration.remove(targetPeer);
-    if (!persistConfigurationUpdate()) {
-      throw new ConsensusGroupAddPeerException(
-          String.format("error when build sync log channel to %s", 
targetPeer));
-    }
+    persistConfigurationUpdate();
   }
 
   public void persistConfiguration() {
@@ -433,7 +441,7 @@ public class MultiLeaderServerImpl {
     }
   }
 
-  public boolean persistConfigurationUpdate() {
+  public void persistConfigurationUpdate() throws 
ConsensusGroupAddPeerException {
     try (PublicBAOS publicBAOS = new PublicBAOS();
         DataOutputStream outputStream = new DataOutputStream(publicBAOS)) {
       serializeConfigurationTo(outputStream);
@@ -444,10 +452,9 @@ public class MultiLeaderServerImpl {
       Files.write(tmpConfigurationPath, publicBAOS.getBuf());
       Files.delete(configurationPath);
       Files.move(tmpConfigurationPath, configurationPath);
-      return true;
     } catch (IOException e) {
-      logger.error("Unexpected error occurs when update configuration", e);
-      return false;
+      throw new ConsensusGroupAddPeerException(
+          "Unexpected error occurs when update configuration", e);
     }
   }