This is an automated email from the ASF dual-hosted git repository.

haonan pushed a commit to branch fix_writing_metric
in repository https://gitbox.apache.org/repos/asf/iotdb.git

commit 15dd767b5d4789a383c99b63c4242e15ad40b834
Author: HTHou <[email protected]>
AuthorDate: Thu Jan 4 14:57:29 2024 +0800

    fix the error of writing metrics
---
 .../iotdb/db/service/metrics/WritingMetrics.java    | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
index cbe693e272b..5d30f6d1b1b 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
@@ -361,19 +361,14 @@ public class WritingMetrics implements IMetricSet {
 
     flushThreholdHistogram =
         MetricService.getInstance()
-            .getOrCreateHistogram(
-                Metric.FLUSH_THRESHOLD.toString(), MetricLevel.IMPORTANT, 
"flush_threshold");
+            .getOrCreateHistogram(Metric.FLUSH_THRESHOLD.toString(), 
MetricLevel.IMPORTANT);
     rejectThreholdHistogram =
         MetricService.getInstance()
-            .getOrCreateHistogram(
-                Metric.REJECT_THRESHOLD.toString(), MetricLevel.IMPORTANT, 
"reject_threshold");
+            .getOrCreateHistogram(Metric.REJECT_THRESHOLD.toString(), 
MetricLevel.IMPORTANT);
 
     memtableLiveTimer =
         MetricService.getInstance()
-            .getOrCreateTimer(
-                Metric.MEMTABLE_LIVE_DURATION.toString(),
-                MetricLevel.IMPORTANT,
-                Tag.STAGE.toString());
+            .getOrCreateTimer(Metric.MEMTABLE_LIVE_DURATION.toString(), 
MetricLevel.IMPORTANT);
   }
 
   public void unbindDataRegionMetrics() {
@@ -390,8 +385,7 @@ public class WritingMetrics implements IMetricSet {
     removeActiveTimePartitionCounterMetrics();
     MetricService.getInstance().remove(MetricType.HISTOGRAM, 
Metric.FLUSH_THRESHOLD.toString());
     MetricService.getInstance().remove(MetricType.HISTOGRAM, 
Metric.REJECT_THRESHOLD.toString());
-    MetricService.getInstance()
-        .remove(MetricType.TIMER, Metric.MEMTABLE_LIVE_DURATION.toString(), 
Tag.STAGE.toString());
+    MetricService.getInstance().remove(MetricType.TIMER, 
Metric.MEMTABLE_LIVE_DURATION.toString());
   }
 
   public void createDataRegionMemoryCostMetrics(DataRegion dataRegion) {
@@ -788,8 +782,6 @@ public class WritingMetrics implements IMetricSet {
             number,
             Metric.TIMED_FLUSH_MEMTABLE_COUNT.toString(),
             MetricLevel.CORE,
-            Tag.NAME.toString(),
-            Tag.NAME.toString(),
             Tag.REGION.toString(),
             dataRegionId);
   }
@@ -800,8 +792,6 @@ public class WritingMetrics implements IMetricSet {
             number,
             Metric.WAL_FLUSH_MEMTABLE_COUNT.toString(),
             MetricLevel.CORE,
-            Tag.NAME.toString(),
-            Tag.NAME.toString(),
             Tag.REGION.toString(),
             dataRegionId);
   }
@@ -812,8 +802,6 @@ public class WritingMetrics implements IMetricSet {
             number,
             Metric.SERIES_FULL_FLUSH_MEMTABLE.toString(),
             MetricLevel.CORE,
-            Tag.NAME.toString(),
-            Tag.NAME.toString(),
             Tag.REGION.toString(),
             dataRegionId);
   }
@@ -824,7 +812,6 @@ public class WritingMetrics implements IMetricSet {
             number,
             Metric.ACTIVE_MEMTABLE_COUNT.toString(),
             MetricLevel.CORE,
-            Tag.NAME.toString(),
             Tag.REGION.toString(),
             dataRegionId);
   }

Reply via email to