(iotdb) branch master updated: Revert: cannot reuse time and column array in InsertTabletStatementGenerator (#16424)

[jackietien]

This is an automated email from the ASF dual-hosted git repository.

jackietien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 89ef1337744 Revert: cannot reuse time and column array in 
InsertTabletStatementGenerator (#16424)
89ef1337744 is described below

commit 89ef133774441891dc2e76767bff454992ad3997
Author: shizy <shiz...@gmail.com>
AuthorDate: Wed Sep 17 17:53:25 2025 +0800

    Revert: cannot reuse time and column array in 
InsertTabletStatementGenerator (#16424)
---
 .../process/InsertTabletStatementGenerator.java    | 39 +---------------------
 .../TableInsertTabletStatementGenerator.java       |  2 +-
 .../TreeInsertTabletStatementGenerator.java        |  2 +-
 3 files changed, 3 insertions(+), 40 deletions(-)

diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/InsertTabletStatementGenerator.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/InsertTabletStatementGenerator.java
index 96b14207e5e..b2fae4c25b1 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/InsertTabletStatementGenerator.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/InsertTabletStatementGenerator.java
@@ -67,7 +67,7 @@ public abstract class InsertTabletStatementGenerator 
implements Accountable {
     this.rowLimit = rowLimit;
   }
 
-  public void initialize() {
+  public void reset() {
     this.rowCount = 0;
     this.times = new long[rowLimit];
     this.columns = new Object[this.measurements.length];
@@ -108,43 +108,6 @@ public abstract class InsertTabletStatementGenerator 
implements Accountable {
     }
   }
 
-  public void reset() {
-    this.rowCount = 0;
-    Arrays.fill(times, 0L);
-    for (int i = 0; i < this.measurements.length; i++) {
-      switch (dataTypes[i]) {
-        case BOOLEAN:
-          Arrays.fill((boolean[]) columns[i], false);
-          break;
-        case INT32:
-        case DATE:
-          Arrays.fill((int[]) columns[i], 0);
-          break;
-        case INT64:
-        case TIMESTAMP:
-          Arrays.fill((long[]) columns[i], 0L);
-          break;
-        case FLOAT:
-          Arrays.fill((float[]) columns[i], 0F);
-          break;
-        case DOUBLE:
-          Arrays.fill((double[]) columns[i], 0D);
-          break;
-        case TEXT:
-        case STRING:
-        case BLOB:
-          Arrays.fill((Binary[]) columns[i], Binary.EMPTY_VALUE);
-          break;
-        default:
-          throw new UnSupportedDataTypeException(
-              String.format("Data type %s is not supported.", dataTypes[i]));
-      }
-    }
-    for (BitMap bitMap : this.bitMaps) {
-      bitMap.markAll();
-    }
-  }
-
   public InsertTabletStatement constructInsertTabletStatement() {
     InsertTabletStatement insertTabletStatement = new InsertTabletStatement();
     insertTabletStatement.setDevicePath(devicePath);
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TableInsertTabletStatementGenerator.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TableInsertTabletStatementGenerator.java
index a263d6d5cac..a8987d652fc 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TableInsertTabletStatementGenerator.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TableInsertTabletStatementGenerator.java
@@ -71,7 +71,7 @@ public class TableInsertTabletStatementGenerator extends 
InsertTabletStatementGe
     this.columnCategories = tsTableColumnCategories.toArray(new 
TsTableColumnCategory[0]);
     this.timeColumnIndex =
         
measurementToInputLocationMap.get(TIME_COLUMN_NAME).getValueColumnIndex();
-    this.initialize();
+    this.reset();
   }
 
   public int processTsBlock(TsBlock tsBlock, int lastReadIndex) {
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TreeInsertTabletStatementGenerator.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TreeInsertTabletStatementGenerator.java
index 41b4617e2f0..3a24312479c 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TreeInsertTabletStatementGenerator.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/TreeInsertTabletStatementGenerator.java
@@ -59,7 +59,7 @@ public class TreeInsertTabletStatementGenerator extends 
InsertTabletStatementGen
     for (String measurement : measurements) {
       writtenCounter.put(measurement, new AtomicLong(0));
     }
-    this.initialize();
+    this.reset();
   }
 
   public int processTsBlock(TsBlock tsBlock, int lastReadIndex) {