This is an automated email from the ASF dual-hosted git repository.
jt2594838 pushed a commit to branch dev/1.3
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/dev/1.3 by this push:
new 12d10a0d416 Pipe: disable serialize-by-region by default (#18140)
12d10a0d416 is described below
commit 12d10a0d416f00b5d8e6b2b53d81d279d6e1e553
Author: Caideyipi <[email protected]>
AuthorDate: Thu Jul 9 14:58:57 2026 +0800
Pipe: disable serialize-by-region by default (#18140)
---
.../iotdb/db/pipe/agent/plugin/PipeDataNodePluginAgentTest.java | 6 +++---
.../pipe/agent/task/subtask/sink/PipeSinkSubtaskManagerTest.java | 8 ++++----
.../iotdb/commons/pipe/config/constant/PipeSinkConstant.java | 2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git
a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/plugin/PipeDataNodePluginAgentTest.java
b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/plugin/PipeDataNodePluginAgentTest.java
index ce898fab64a..67109e7a602 100644
---
a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/plugin/PipeDataNodePluginAgentTest.java
+++
b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/plugin/PipeDataNodePluginAgentTest.java
@@ -134,17 +134,17 @@ public class PipeDataNodePluginAgentTest {
}))
.getClass());
Assert.assertEquals(
- IoTDBDataRegionSyncSink.class,
+ IoTDBDataRegionAsyncSink.class,
agent.dataRegion().reflectSink(new PipeParameters(new
HashMap<>())).getClass());
Assert.assertEquals(
- IoTDBDataRegionAsyncSink.class,
+ IoTDBDataRegionSyncSink.class,
agent
.dataRegion()
.reflectSink(
new PipeParameters(
new HashMap<String, String>() {
{
-
put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY, "false");
+
put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY, "true");
}
}))
.getClass());
diff --git
a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeSinkSubtaskManagerTest.java
b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeSinkSubtaskManagerTest.java
index 9545d71d965..dad19044251 100644
---
a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeSinkSubtaskManagerTest.java
+++
b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/agent/task/subtask/sink/PipeSinkSubtaskManagerTest.java
@@ -33,20 +33,20 @@ import java.util.Map;
public class PipeSinkSubtaskManagerTest {
@Test
- public void
testGenerateAttributeSortedStringAddsRegionPrefixAndIgnoresRestartFlag() {
+ public void
testGenerateAttributeSortedStringUsesSerializeByRegionAndIgnoresRestartFlag() {
final Map<String, String> attributes = new HashMap<>();
attributes.put("z", "1");
attributes.put("a", "2");
attributes.put(SystemConstant.RESTART_OR_NEWLY_ADDED_KEY,
Boolean.TRUE.toString());
Assert.assertEquals(
- "data_region_-1_{a=2, z=1}",
+ "data_{a=2, z=1}",
PipeSinkSubtaskManager.generateAttributeSortedString(
new PipeParameters(new HashMap<>(attributes)), -1));
- attributes.put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY,
Boolean.FALSE.toString());
+ attributes.put(PipeSinkConstant.CONNECTOR_SERIALIZE_BY_REGION_KEY,
Boolean.TRUE.toString());
Assert.assertEquals(
- "data_{a=2, connector.serialize-by-region=false, z=1}",
+ "data_region_-1_{a=2, connector.serialize-by-region=true, z=1}",
PipeSinkSubtaskManager.generateAttributeSortedString(
new PipeParameters(new HashMap<>(attributes)), -1));
}
diff --git
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeSinkConstant.java
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeSinkConstant.java
index 083d4bfbf73..e170e8e7828 100644
---
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeSinkConstant.java
+++
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeSinkConstant.java
@@ -71,7 +71,7 @@ public class PipeSinkConstant {
public static final String CONNECTOR_SERIALIZE_BY_REGION_KEY =
"connector.serialize-by-region";
public static final String SINK_SERIALIZE_BY_REGION_KEY =
"sink.serialize-by-region";
- public static final boolean CONNECTOR_SERIALIZE_BY_REGION_DEFAULT_VALUE =
true;
+ public static final boolean CONNECTOR_SERIALIZE_BY_REGION_DEFAULT_VALUE =
false;
public static boolean isSerializeByRegionEnabled(final PipeParameters
parameters) {
return parameters.getBooleanOrDefault(