Repository: jclouds-labs Updated Branches: refs/heads/master 4cb6b9ec2 -> 4e54f16dc
Make constants final classes instead of interfaces This commit prohibits implementation of the empty interface and instantiation of the class. Refer to _Effective Java_ item 19 for more background. Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/4e54f16d Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs/tree/4e54f16d Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs/diff/4e54f16d Branch: refs/heads/master Commit: 4e54f16dcce18a2866eea23205c03a1bc02667f0 Parents: 4cb6b9e Author: Andrew Gaul <[email protected]> Authored: Fri May 16 09:46:12 2014 -0700 Committer: Andrew Gaul <[email protected]> Committed: Fri May 16 09:46:12 2014 -0700 ---------------------------------------------------------------------- .../java/org/jclouds/abiquo/reference/AbiquoTestConstants.java | 6 +++++- dmtf/src/main/java/org/jclouds/dmtf/DMTFConstants.java | 6 +++++- .../java/org/jclouds/savvis/vpdc/reference/VPDCConstants.java | 5 ++++- .../jclouds/vcloud/director/v1_5/VCloudDirectorConstants.java | 6 +++++- .../vcloud/director/v1_5/VCloudDirectorLiveTestConstants.java | 5 ++++- .../org/jclouds/virtualbox/config/VirtualBoxConstants.java | 6 +++++- 6 files changed, 28 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/4e54f16d/abiquo/src/test/java/org/jclouds/abiquo/reference/AbiquoTestConstants.java ---------------------------------------------------------------------- diff --git a/abiquo/src/test/java/org/jclouds/abiquo/reference/AbiquoTestConstants.java b/abiquo/src/test/java/org/jclouds/abiquo/reference/AbiquoTestConstants.java index 2e7a765..b8f2b8f 100644 --- a/abiquo/src/test/java/org/jclouds/abiquo/reference/AbiquoTestConstants.java +++ b/abiquo/src/test/java/org/jclouds/abiquo/reference/AbiquoTestConstants.java @@ -21,7 +21,11 @@ package org.jclouds.abiquo.reference; * * @author Ignasi Barrera */ -public interface AbiquoTestConstants { +public final class AbiquoTestConstants { /** The prefix for test object names. */ public static final String PREFIX = "JC-"; + + private AbiquoTestConstants() { + throw new AssertionError("intentionally unimplemented"); + } } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/4e54f16d/dmtf/src/main/java/org/jclouds/dmtf/DMTFConstants.java ---------------------------------------------------------------------- diff --git a/dmtf/src/main/java/org/jclouds/dmtf/DMTFConstants.java b/dmtf/src/main/java/org/jclouds/dmtf/DMTFConstants.java index d4dec65..85b8877 100644 --- a/dmtf/src/main/java/org/jclouds/dmtf/DMTFConstants.java +++ b/dmtf/src/main/java/org/jclouds/dmtf/DMTFConstants.java @@ -21,7 +21,7 @@ package org.jclouds.dmtf; * * @author [email protected] */ -public class DMTFConstants { +public final class DMTFConstants { public static final String OVF_NS = "http://schemas.dmtf.org/ovf/envelope/1";; @@ -32,4 +32,8 @@ public class DMTFConstants { public static final String CIM_VSSD_NS = "http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_VirtualSystemSettingData";; public static final String CIM_RASD_NS = "http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_ResourceAllocationSettingData";; + + private DMTFConstants() { + throw new AssertionError("intentionally unimplemented"); + } } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/4e54f16d/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/reference/VPDCConstants.java ---------------------------------------------------------------------- diff --git a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/reference/VPDCConstants.java b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/reference/VPDCConstants.java index 62806bf..1a25771 100644 --- a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/reference/VPDCConstants.java +++ b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/reference/VPDCConstants.java @@ -21,7 +21,7 @@ package org.jclouds.savvis.vpdc.reference; * * @author Adrian Cole */ -public interface VPDCConstants { +public final class VPDCConstants { /** * which email must be present for VDCs to be considered yours @@ -30,4 +30,7 @@ public interface VPDCConstants { public static final String PROPERTY_VPDC_TIMEOUT_TASK_COMPLETED = "jclouds.vpdc.timeout.task-complete"; + private VPDCConstants() { + throw new AssertionError("intentionally unimplemented"); + } } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/4e54f16d/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorConstants.java ---------------------------------------------------------------------- diff --git a/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorConstants.java b/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorConstants.java index 9119440..0db4283 100644 --- a/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorConstants.java +++ b/vcloud-director/src/main/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorConstants.java @@ -27,7 +27,7 @@ import com.google.common.reflect.TypeToken; * * @author [email protected] */ -public class VCloudDirectorConstants { +public final class VCloudDirectorConstants { /** The XML namespace used by the apis. */ public static final String VCLOUD_1_5_NS = "http://www.vmware.com/vcloud/v1.5";; @@ -72,4 +72,8 @@ public class VCloudDirectorConstants { public static final TypeToken<RestContext<SessionApi, SessionAsyncApi>> SESSION_CONTEXT_TYPE = new TypeToken<RestContext<SessionApi, SessionAsyncApi>>() { }; + + private VCloudDirectorConstants() { + throw new AssertionError("intentionally unimplemented"); + } } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/4e54f16d/vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorLiveTestConstants.java ---------------------------------------------------------------------- diff --git a/vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorLiveTestConstants.java b/vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorLiveTestConstants.java index 066d456..42e5eab 100644 --- a/vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorLiveTestConstants.java +++ b/vcloud-director/src/test/java/org/jclouds/vcloud/director/v1_5/VCloudDirectorLiveTestConstants.java @@ -19,7 +19,7 @@ package org.jclouds.vcloud.director.v1_5; /** * @author [email protected] */ -public class VCloudDirectorLiveTestConstants { +public final class VCloudDirectorLiveTestConstants { /* regular expressions for pattern matching */ @@ -103,4 +103,7 @@ public class VCloudDirectorLiveTestConstants { public static final String ENTITY_CONDITION = "ERR-303: The %s entity must %s (%s)"; + private VCloudDirectorLiveTestConstants() { + throw new AssertionError("intentionally unimplemented"); + } } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/4e54f16d/virtualbox/src/main/java/org/jclouds/virtualbox/config/VirtualBoxConstants.java ---------------------------------------------------------------------- diff --git a/virtualbox/src/main/java/org/jclouds/virtualbox/config/VirtualBoxConstants.java b/virtualbox/src/main/java/org/jclouds/virtualbox/config/VirtualBoxConstants.java index f276087..5588153 100644 --- a/virtualbox/src/main/java/org/jclouds/virtualbox/config/VirtualBoxConstants.java +++ b/virtualbox/src/main/java/org/jclouds/virtualbox/config/VirtualBoxConstants.java @@ -24,7 +24,7 @@ import java.io.File; * @author Mattias Holmqvist, Andrea Turli, David Alves * */ -public interface VirtualBoxConstants { +public final class VirtualBoxConstants { public static final String VIRTUALBOX_NODE_NAME_SEPARATOR = "-0x0-"; @@ -62,4 +62,8 @@ public interface VirtualBoxConstants { public static final String GUEST_OS_PASSWORD = "guestPassword"; public static final String GUEST_OS_USER = "guestUser"; + + private CloudSigmaConstants() { + throw new AssertionError("intentionally unimplemented"); + } }
