Repository: jclouds Updated Branches: refs/heads/master 309c053c7 -> 5b5e713cb
Avoid unnecessary object creation Prefer StringBuffer.append(string, index1, index2) over StringBuffer.append(String.substring(index1, index2). Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/5b5e713c Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/5b5e713c Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/5b5e713c Branch: refs/heads/master Commit: 5b5e713cba5945841604769624ee0eff58e88078 Parents: 309c053 Author: Andrew Gaul <[email protected]> Authored: Tue Jun 24 11:52:28 2014 -0700 Committer: Andrew Gaul <[email protected]> Committed: Tue Jun 24 13:15:18 2014 -0700 ---------------------------------------------------------------------- .../src/main/java/org/jclouds/compute/functions/Sha512Crypt.java | 2 +- core/src/main/java/org/jclouds/util/Strings2.java | 4 ++-- .../java/org/jclouds/scriptbuilder/statements/chef/ChefSolo.java | 3 ++- .../src/main/java/org/jclouds/scriptbuilder/util/Utils.java | 4 ++-- 4 files changed, 7 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds/blob/5b5e713c/compute/src/main/java/org/jclouds/compute/functions/Sha512Crypt.java ---------------------------------------------------------------------- diff --git a/compute/src/main/java/org/jclouds/compute/functions/Sha512Crypt.java b/compute/src/main/java/org/jclouds/compute/functions/Sha512Crypt.java index 7901fbc..c19ae9b 100644 --- a/compute/src/main/java/org/jclouds/compute/functions/Sha512Crypt.java +++ b/compute/src/main/java/org/jclouds/compute/functions/Sha512Crypt.java @@ -174,7 +174,7 @@ public class Sha512Crypt { while (saltBuf.length() < 16) { int index = (int) (randgen.nextFloat() * SALTCHARS.length()); - saltBuf.append(SALTCHARS.substring(index, index + 1)); + saltBuf.append(SALTCHARS, index, index + 1); } shadowPrefix = saltBuf.toString(); http://git-wip-us.apache.org/repos/asf/jclouds/blob/5b5e713c/core/src/main/java/org/jclouds/util/Strings2.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/jclouds/util/Strings2.java b/core/src/main/java/org/jclouds/util/Strings2.java index 1d52a60..53bc3a1 100644 --- a/core/src/main/java/org/jclouds/util/Strings2.java +++ b/core/src/main/java/org/jclouds/util/Strings2.java @@ -160,14 +160,14 @@ public class Strings2 { int i = 0; while (matcher.find()) { String replacement = replacements.get(matcher.group(1)); - builder.append(input.substring(i, matcher.start())); + builder.append(input, i, matcher.start()); if (replacement == null) builder.append(matcher.group(0)); else builder.append(replacement); i = matcher.end(); } - builder.append(input.substring(i, input.length())); + builder.append(input, i, input.length()); return builder.toString(); } http://git-wip-us.apache.org/repos/asf/jclouds/blob/5b5e713c/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/chef/ChefSolo.java ---------------------------------------------------------------------- diff --git a/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/chef/ChefSolo.java b/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/chef/ChefSolo.java index 819b2b3..4334d7c 100644 --- a/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/chef/ChefSolo.java +++ b/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/chef/ChefSolo.java @@ -369,7 +369,8 @@ public class ChefSolo implements Statement { if (jsonAttributes.isPresent()) { // Start the node configuration with the attributes, but remove the // last bracket to append the run list to the json configuration - json.append(jsonAttributes.get().substring(0, jsonAttributes.get().lastIndexOf('}'))); + String attributes = jsonAttributes.get(); + json.append(attributes, 0, attributes.lastIndexOf('}')); json.append(","); } else { json.append("{"); http://git-wip-us.apache.org/repos/asf/jclouds/blob/5b5e713c/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/util/Utils.java ---------------------------------------------------------------------- diff --git a/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/util/Utils.java b/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/util/Utils.java index 023cfb5..5607461 100644 --- a/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/util/Utils.java +++ b/scriptbuilder/src/main/java/org/jclouds/scriptbuilder/util/Utils.java @@ -86,14 +86,14 @@ public class Utils { int i = 0; while (matcher.find()) { String replacement = replacements.get(matcher.group(1)); - builder.append(input.substring(i, matcher.start())); + builder.append(input, i, matcher.start()); if (replacement == null) builder.append(matcher.group(0)); else builder.append(replacement); i = matcher.end(); } - builder.append(input.substring(i, input.length())); + builder.append(input, i, input.length()); return builder.toString(); }
