Repository: jclouds-labs Updated Branches: refs/heads/master f5ce36664 -> 9798b5138
Reset StringBuilder instead of creating new ones This avoids unneeded garbage, especially during XML parsing. Replaced with: find -name \*.java | xargs sed -i 's/^\( *[^ ]*\) = new StringBuilder();$/\1.setLength(0);/' Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/9798b513 Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs/tree/9798b513 Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs/diff/9798b513 Branch: refs/heads/master Commit: 9798b5138c056118b8a2b6f2b9c0713025f4185f Parents: f5ce366 Author: Andrew Gaul <[email protected]> Authored: Wed Aug 6 11:26:21 2014 -0700 Committer: Andrew Gaul <[email protected]> Committed: Wed Aug 6 11:26:21 2014 -0700 ---------------------------------------------------------------------- .../java/org/jclouds/azure/management/xml/AttachmentHandler.java | 2 +- .../java/org/jclouds/azure/management/xml/DeploymentHandler.java | 2 +- .../management/xml/DetailedHostedServicePropertiesHandler.java | 2 +- .../main/java/org/jclouds/azure/management/xml/DiskHandler.java | 2 +- .../main/java/org/jclouds/azure/management/xml/ErrorHandler.java | 2 +- .../org/jclouds/azure/management/xml/HostedServiceHandler.java | 2 +- .../azure/management/xml/HostedServicePropertiesHandler.java | 2 +- .../java/org/jclouds/azure/management/xml/LocationHandler.java | 2 +- .../main/java/org/jclouds/azure/management/xml/OSImageHandler.java | 2 +- .../java/org/jclouds/azure/management/xml/OperationHandler.java | 2 +- .../main/java/org/jclouds/savvis/vpdc/xml/FirewallRuleHandler.java | 2 +- .../java/org/jclouds/savvis/vpdc/xml/FirewallServiceHandler.java | 2 +- .../src/main/java/org/jclouds/savvis/vpdc/xml/NetworkHandler.java | 2 +- .../src/main/java/org/jclouds/savvis/vpdc/xml/OrgHandler.java | 2 +- .../src/main/java/org/jclouds/savvis/vpdc/xml/VDCHandler.java | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java index 4c23a89..70699d8 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java @@ -53,7 +53,7 @@ public class AttachmentHandler extends ParseSax.HandlerForGeneratedRequestWithRe } else if (qName.equals("RoleName")) { builder.role(SaxUtils.currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java index 83805e9..68eaf22 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java @@ -111,7 +111,7 @@ public class DeploymentHandler extends builder.publicIpAddress(currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); elements.remove(elements.size()-1); } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java index 901c765..fef02d7 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java @@ -75,7 +75,7 @@ public class DetailedHostedServicePropertiesHandler extends HostedServicePropert } else { super.endElement(uri, name, qName); } - currentText = new StringBuilder(); + currentText.setLength(0); } } http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java index 2da98f6..0dc7fb8 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java @@ -101,7 +101,7 @@ public class DiskHandler extends } else if (equalsOrSuffix(qName, "Label")) { builder.label(currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java index f9dfac9..459346b 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java @@ -54,7 +54,7 @@ public class ErrorHandler extends ParseSax.HandlerForGeneratedRequestWithResult< } else if (qName.equals("Message")) { builder.message(SaxUtils.currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java index 7c0cd22..e5060e2 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java @@ -91,7 +91,7 @@ public class HostedServiceHandler extends ParseSax.HandlerForGeneratedRequestWit } else if (equalsOrSuffix(qName, "ServiceName")) { builder.name(currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java index 6a7f732..3d7dfb2 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java @@ -60,7 +60,7 @@ public class HostedServicePropertiesHandler extends } else if (equalsOrSuffix(qName, "Label")) { builder.label(new String(base64().decode(currentOrNull(currentText)), UTF_8)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java index 31bcd21..6313820 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java @@ -53,7 +53,7 @@ public class LocationHandler extends ParseSax.HandlerForGeneratedRequestWithResu } else if (qName.equals("AvailableService")) { builder.addAvailableService(SaxUtils.currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/OSImageHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/OSImageHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/OSImageHandler.java index a204929..22508e8 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/OSImageHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/OSImageHandler.java @@ -78,7 +78,7 @@ public class OSImageHandler extends ParseSax.HandlerForGeneratedRequestWithResul } else if (equalsOrSuffix(qName, "Label")) { builder.label(currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java ---------------------------------------------------------------------- diff --git a/azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java b/azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java index e3c9d36..816a0d7 100644 --- a/azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java +++ b/azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java @@ -93,7 +93,7 @@ public class OperationHandler extends ParseSax.HandlerForGeneratedRequestWithRes } else if (equalsOrSuffix(qName, "HttpStatusCode")) { builder.httpStatusCode(Integer.parseInt(currentOrNull(currentText))); } - currentText = new StringBuilder(); + currentText.setLength(0); } /** http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallRuleHandler.java ---------------------------------------------------------------------- diff --git a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallRuleHandler.java b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallRuleHandler.java index 3a0acca..53f0765 100644 --- a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallRuleHandler.java +++ b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallRuleHandler.java @@ -69,7 +69,7 @@ public class FirewallRuleHandler extends ParseSax.HandlerWithResult<FirewallRule builder.protocol("Icmp-ping"); } } - currentText = new StringBuilder(); + currentText.setLength(0); } @Override http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallServiceHandler.java ---------------------------------------------------------------------- diff --git a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallServiceHandler.java b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallServiceHandler.java index 8c25d4d..7386915 100644 --- a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallServiceHandler.java +++ b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/FirewallServiceHandler.java @@ -74,7 +74,7 @@ public class FirewallServiceHandler extends ParseSax.HandlerWithResult<FirewallS if (inFirewallRule) { firewallRuleHandler.endElement(uri, localName, qName); } - currentText = new StringBuilder(); + currentText.setLength(0); } @Override http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/NetworkHandler.java ---------------------------------------------------------------------- diff --git a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/NetworkHandler.java b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/NetworkHandler.java index 29fd9fa..73930f3 100644 --- a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/NetworkHandler.java +++ b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/NetworkHandler.java @@ -66,7 +66,7 @@ public class NetworkHandler extends ParseSax.HandlerWithResult<Network> { } else if (equalsOrSuffix(qName, "Netmask")) { builder.netmask(currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } public void characters(char ch[], int start, int length) { http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/OrgHandler.java ---------------------------------------------------------------------- diff --git a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/OrgHandler.java b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/OrgHandler.java index 878526a..e2265d9 100644 --- a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/OrgHandler.java +++ b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/OrgHandler.java @@ -69,7 +69,7 @@ public class OrgHandler extends ParseSax.HandlerWithResult<Org> { if (equalsOrSuffix(qName, "Description")) { builder.description(currentOrNull(currentText)); } - currentText = new StringBuilder(); + currentText.setLength(0); } public void characters(char ch[], int start, int length) { http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/9798b513/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/VDCHandler.java ---------------------------------------------------------------------- diff --git a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/VDCHandler.java b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/VDCHandler.java index 5160cec..25df229 100644 --- a/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/VDCHandler.java +++ b/savvis-symphonyvpdc/src/main/java/org/jclouds/savvis/vpdc/xml/VDCHandler.java @@ -69,7 +69,7 @@ public class VDCHandler extends ParseSax.HandlerWithResult<VDC> { } else if (equalsOrSuffix(qName, "OfferingTag")) { builder.status(Status.fromValue(currentOrNull(currentText))); } - currentText = new StringBuilder(); + currentText.setLength(0); } public void characters(char ch[], int start, int length) {
