Repository: jclouds-labs-google Updated Branches: refs/heads/1.8.x bee989855 -> 2f92f1c67
JCLOUDS-661: Adding a test for single-port firewall rules Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/commit/2f92f1c6 Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/tree/2f92f1c6 Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/diff/2f92f1c6 Branch: refs/heads/1.8.x Commit: 2f92f1c67d0fca546cb892c294624ee926de02db Parents: bee9898 Author: Stuart Hendren <[email protected]> Authored: Tue Aug 12 10:26:05 2014 +0100 Committer: Chris Custine <[email protected]> Committed: Thu Aug 14 14:49:01 2014 -0600 ---------------------------------------------------------------------- .../GoogleComputeEngineSecurityGroupExtension.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds-labs-google/blob/2f92f1c6/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java ---------------------------------------------------------------------- diff --git a/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java b/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java index f1113e0..8d5a10c 100644 --- a/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java +++ b/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/extensions/GoogleComputeEngineSecurityGroupExtension.java @@ -220,8 +220,12 @@ public class GoogleComputeEngineSecurityGroupExtension implements SecurityGroupE } Firewall.Rule.Builder ruleBuilder = Firewall.Rule.builder(); ruleBuilder.IpProtocol(ipPermission.getIpProtocol()); - if (ipPermission.getToPort() > 0) { - ruleBuilder.addPortRange(ipPermission.getFromPort(), ipPermission.getToPort()); + if (ipPermission.getFromPort() > 0) { + if (ipPermission.getFromPort() == ipPermission.getToPort()) { + ruleBuilder.addPort(ipPermission.getToPort()); + } else { + ruleBuilder.addPortRange(ipPermission.getFromPort(), ipPermission.getToPort()); + } } fwOptions.addAllowedRule(ruleBuilder.build());
