Repository: jclouds-labs Updated Branches: refs/heads/master 64814816f -> bec869d68
Prefer isEmpty() to size() Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/bec869d6 Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs/tree/bec869d6 Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs/diff/bec869d6 Branch: refs/heads/master Commit: bec869d684b7e904cb50dd74d601b8f6d5297a08 Parents: 6481481 Author: Jeremy Daggett <[email protected]> Authored: Wed Sep 24 19:20:57 2014 -0700 Committer: Jeremy Daggett <[email protected]> Committed: Thu Sep 25 06:42:07 2014 -0700 ---------------------------------------------------------------------- .../org/jclouds/cloudsigma2/CloudSigma2ApiLiveTest.java | 10 +++++----- .../fujitsu/fgcp/services/VirtualDCApiLiveTest.java | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/bec869d6/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiLiveTest.java ---------------------------------------------------------------------- diff --git a/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiLiveTest.java b/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiLiveTest.java index af98d3a..5fcf1bb 100644 --- a/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiLiveTest.java +++ b/cloudsigma2/src/test/java/org/jclouds/cloudsigma2/CloudSigma2ApiLiveTest.java @@ -157,7 +157,7 @@ public class CloudSigma2ApiLiveTest extends BaseApiLiveTest<CloudSigma2Api> { } ImmutableList<String> uuids = stringListBuilder.build(); api.deleteDrives(uuids); - + // Verify all deleted drives no longer exist FluentIterable<Drive> drives = api.listDrives().concat(); assertFalse(any(transform(drives, extractUuid()), in(uuids))); @@ -257,7 +257,7 @@ public class CloudSigma2ApiLiveTest extends BaseApiLiveTest<CloudSigma2Api> { } ImmutableList<String> uuids = stringListBuilder.build(); api.deleteServers(uuids); - + // Verify all deleted servers no longer exist FluentIterable<Server> servers = api.listServers().concat(); assertFalse(any(transform(servers, extractUuid()), in(uuids))); @@ -429,7 +429,7 @@ public class CloudSigma2ApiLiveTest extends BaseApiLiveTest<CloudSigma2Api> { .meta(meta) .build(); - if (api.listVLANs().size() > 0) { + if (!api.listVLANs().isEmpty()) { checkVlAN(vlanInfo, api.editVLAN(api.listVLANs().concat().get(0).getUuid(), vlanInfo)); } } @@ -460,7 +460,7 @@ public class CloudSigma2ApiLiveTest extends BaseApiLiveTest<CloudSigma2Api> { .meta(meta) .build(); - if (api.listIPs().size() > 0) { + if (!api.listIPs().isEmpty()) { checkIP(ip, api.editIP(api.listIPs().concat().get(0).getUuid(), ip)); } } @@ -707,7 +707,7 @@ public class CloudSigma2ApiLiveTest extends BaseApiLiveTest<CloudSigma2Api> { assertEquals(newProfileInfo.getLastName(), createdProfileInfo.getLastName()); assertEquals(newProfileInfo.getTown(), createdProfileInfo.getTown()); } - + private static Function<Item, String> extractUuid() { return new Function<Item, String>() { @Override http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/bec869d6/fgcp/src/test/java/org/jclouds/fujitsu/fgcp/services/VirtualDCApiLiveTest.java ---------------------------------------------------------------------- diff --git a/fgcp/src/test/java/org/jclouds/fujitsu/fgcp/services/VirtualDCApiLiveTest.java b/fgcp/src/test/java/org/jclouds/fujitsu/fgcp/services/VirtualDCApiLiveTest.java index 88a5d49..ed9a6c4 100644 --- a/fgcp/src/test/java/org/jclouds/fujitsu/fgcp/services/VirtualDCApiLiveTest.java +++ b/fgcp/src/test/java/org/jclouds/fujitsu/fgcp/services/VirtualDCApiLiveTest.java @@ -36,7 +36,7 @@ public class VirtualDCApiLiveTest extends BaseFGCPApiLiveTest { Set<VSystem> vsysSet = api.getVirtualDCApi().listVirtualSystems(); assertNotNull(vsysSet, "vsysSet"); - assertTrue(vsysSet.size() > 0, "vsysSet.size() should be greater than 0"); + assertTrue(!vsysSet.isEmpty(), "vsysSet.size() should be greater than 0"); for (VSystem vsys : vsysSet) { System.out.println(vsys); }
