Dear Wiki user, You have subscribed to a wiki page or wiki category on "Jclouds Wiki" for change notification.
The "How to contribute" page has been changed by AndrewPhillips: https://wiki.apache.org/jclouds/How%20to%20contribute?action=diff&rev1=10&rev2=11 === 2. Create a pull request in GitHub === - Next, you'll want to create a pull request (PR) in !GitHub for the change you're interested in making. The comment section of the PR must contain a link to the JIRA issue (if it has one). If you need the commit backported to one of the release branches (e.g. 1.6.x), make a note about that in the comment too. + Next, you'll want to create a pull request (PR) in !GitHub for the change you're interested in making. The comment section of the PR must contain a link to the JIRA issue (if it has one). Please also reference the issue [[https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=commit;h=ff3405c967b9fd6701fa39c6bb57d0308dd6e1e6|in the commit message]]. If you need the commit backported to one of the release branches (e.g. 1.6.x), make a note about that in the comment too and set the Affects Version/s of the issue accordingly. Some good references for working with !GitHub are below. We ask that you keep your change rebased to master as much as possible, and we will ask you to rebase again if master has moved before accepting your patch. * [[https://help.github.com/articles/set-up-git|Setting Up Git with GitHub]] * [[https://help.github.com/articles/fork-a-repo|Forking a Repository]] * [[https://help.github.com/articles/using-pull-requests|Submitting Pull Requests]] - * [[https://help.github.com/articles/interactive-rebase|Rebase]] + * [[https://help.github.com/articles/interactive-rebase|Rebasing your Branch]] === 3. Comment the issue in JIRA === Finally, add a comment in the JIRA issue with a link to the pull request so we know the code is ready to be reviewed. - If you need the commit backported to one of the release branches (e.g. 1.6.x), make a note about that in the comment too. - == The review process == - Someone will review your pull request before it is merged. This process can take a while. + The jclouds community will review your pull request before it is merged. This process can take a while, so please be patient. If we are slow to respond, feel free to join us in irc on [[http://webchat.freenode.net/?channels=#jclouds|irc.freenode.net #jclouds]] and ask for help. Feel free to also email our dev [[http://incubator.apache.org/projects/jclouds.html|mailing list]]: [[mailto:[email protected]|[email protected]]]. To subscribe send an email to [[mailto:[email protected]|[email protected]]]. - During the review process you may be asked to do some changes. While working through feedback, it can be beneficial to create new commits so the incremental change is obvious. This can also lead to a complex set of commits, and having an atomic change per commit is preferred in the end. Use your best judgement and work with your reviewer as to when you should revise a commit or create a new one. + During the review process you may be asked to make some changes to your submission. While working through feedback, it can be beneficial to create new commits so the incremental change is obvious. This can also lead to a complex set of commits, and having an atomic change per commit is preferred in the end. Use your best judgement and work with your reviewer as to when you should revise a commit or create a new one. - A pull request is considered ready to be merged once it gets at lease one +1 from a reviewer. Once all the changes are done and the pull request is accepted, it '''__must be rebased to the latest upstream version__'''. It is also a good idea to squash all the commits into a single one, since this will allow us to generate a clean patch and merge it properly. + A pull request is considered ready to be merged once it gets at lease one +1 from a reviewer. Once all the changes have been completed and the pull request is accepted, it '''__must be rebased to the latest upstream version__'''. It is also a good idea to squash all the commits into a single one, since this will allow us to generate a clean patch and merge it properly.
