Updated Branches: refs/heads/master d52f46056 -> ac58a70e3
Do not eagerly check for existence in FilePayload This is a TOCTOU violation and FilePayload.getInput already propagates this. This commit allows external callers like jclouds-cli to introspect on the exception type, returning a more friendly error message in some situations. Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/commit/ac58a70e Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/tree/ac58a70e Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/diff/ac58a70e Branch: refs/heads/master Commit: ac58a70e3239a2ed637b869107e04e007bdbce58 Parents: d52f460 Author: Andrew Gaul <[email protected]> Authored: Mon Jul 15 23:26:42 2013 -0700 Committer: Andrew Gaul <[email protected]> Committed: Mon Jul 15 23:34:12 2013 -0700 ---------------------------------------------------------------------- core/src/main/java/org/jclouds/io/payloads/FilePayload.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/ac58a70e/core/src/main/java/org/jclouds/io/payloads/FilePayload.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/jclouds/io/payloads/FilePayload.java b/core/src/main/java/org/jclouds/io/payloads/FilePayload.java index 330c0c0..b60616a 100644 --- a/core/src/main/java/org/jclouds/io/payloads/FilePayload.java +++ b/core/src/main/java/org/jclouds/io/payloads/FilePayload.java @@ -34,7 +34,7 @@ public class FilePayload extends BasePayload<File> { public FilePayload(File content) { super(content); getContentMetadata().setContentLength(content.length()); - checkArgument(checkNotNull(content, "content").exists(), "file must exist: " + content); + checkNotNull(content, "content"); } /**
