Updated Branches: refs/heads/master 3ad6b275d -> d8490f872
Enable some Xlint warnings Also address a handful of warnings. Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/commit/d8490f87 Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/tree/d8490f87 Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/diff/d8490f87 Branch: refs/heads/master Commit: d8490f872d4b4c63d11026a00a1227f7fa86b5e2 Parents: 3ad6b27 Author: Andrew Gaul <[email protected]> Authored: Tue Sep 3 05:54:48 2013 -0700 Committer: Andrew Gaul <[email protected]> Committed: Wed Sep 4 19:45:44 2013 -0700 ---------------------------------------------------------------------- .../main/java/org/jclouds/cloudsigma/domain/SCSIDevice.java | 2 -- .../main/java/org/jclouds/cloudstack/domain/AsyncJob.java | 4 ++-- .../java/org/jclouds/elasticstack/domain/SCSIDevice.java | 2 -- .../java/org/jclouds/rest/AnonymousRestApiMetadata.java | 1 + .../java/org/jclouds/rest/internal/BaseRestApiMetadata.java | 1 + project/pom.xml | 9 +++++++++ .../src/main/java/org/jclouds/aws/s3/AWSS3AsyncClient.java | 1 + .../ultradns/ws/handlers/UltraDNSWSErrorHandler.java | 1 + 8 files changed, 15 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/domain/SCSIDevice.java ---------------------------------------------------------------------- diff --git a/apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/domain/SCSIDevice.java b/apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/domain/SCSIDevice.java index 9abe19b..b396057 100644 --- a/apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/domain/SCSIDevice.java +++ b/apis/cloudsigma/src/main/java/org/jclouds/cloudsigma/domain/SCSIDevice.java @@ -64,8 +64,6 @@ public class SCSIDevice extends Device { if (getClass() != obj.getClass()) return false; SCSIDevice other = (SCSIDevice) obj; - if (bus != other.bus) - return false; if (unit != other.unit) return false; return true; http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/AsyncJob.java ---------------------------------------------------------------------- diff --git a/apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/AsyncJob.java b/apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/AsyncJob.java index e4b3673..9c8d8eb 100644 --- a/apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/AsyncJob.java +++ b/apis/cloudstack/src/main/java/org/jclouds/cloudstack/domain/AsyncJob.java @@ -257,7 +257,7 @@ public class AsyncJob<S> { .error(in.getError()); } - public static Builder<?, Object> fromAsyncJobUntyped(AsyncJob in) { + public static Builder<?, Object> fromAsyncJobUntyped(AsyncJob<?> in) { return new ConcreteBuilder().fromAsyncJob(in); } } @@ -426,7 +426,7 @@ public class AsyncJob<S> { public boolean equals(Object obj) { if (this == obj) return true; if (obj == null || getClass() != obj.getClass()) return false; - AsyncJob that = AsyncJob.class.cast(obj); + AsyncJob<?> that = AsyncJob.class.cast(obj); return Objects.equal(this.accountId, that.accountId) && Objects.equal(this.cmd, that.cmd) && Objects.equal(this.created, that.created) http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/apis/elasticstack/src/main/java/org/jclouds/elasticstack/domain/SCSIDevice.java ---------------------------------------------------------------------- diff --git a/apis/elasticstack/src/main/java/org/jclouds/elasticstack/domain/SCSIDevice.java b/apis/elasticstack/src/main/java/org/jclouds/elasticstack/domain/SCSIDevice.java index ffa7934..2754c51 100644 --- a/apis/elasticstack/src/main/java/org/jclouds/elasticstack/domain/SCSIDevice.java +++ b/apis/elasticstack/src/main/java/org/jclouds/elasticstack/domain/SCSIDevice.java @@ -64,8 +64,6 @@ public class SCSIDevice extends Device { if (getClass() != obj.getClass()) return false; SCSIDevice other = (SCSIDevice) obj; - if (bus != other.bus) - return false; if (unit != other.unit) return false; return true; http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/core/src/main/java/org/jclouds/rest/AnonymousRestApiMetadata.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/jclouds/rest/AnonymousRestApiMetadata.java b/core/src/main/java/org/jclouds/rest/AnonymousRestApiMetadata.java index a434679..c96c650 100644 --- a/core/src/main/java/org/jclouds/rest/AnonymousRestApiMetadata.java +++ b/core/src/main/java/org/jclouds/rest/AnonymousRestApiMetadata.java @@ -31,6 +31,7 @@ import com.google.common.annotations.Beta; * async interface will be removed in jclouds 1.7. */ @Beta +@Deprecated public class AnonymousRestApiMetadata extends BaseRestApiMetadata { public static AnonymousRestApiMetadata forClientMappedToAsyncClient(Class<?> client, Class<?> asyncClient) { http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/core/src/main/java/org/jclouds/rest/internal/BaseRestApiMetadata.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/jclouds/rest/internal/BaseRestApiMetadata.java b/core/src/main/java/org/jclouds/rest/internal/BaseRestApiMetadata.java index 6b9d3033..efc3002 100644 --- a/core/src/main/java/org/jclouds/rest/internal/BaseRestApiMetadata.java +++ b/core/src/main/java/org/jclouds/rest/internal/BaseRestApiMetadata.java @@ -38,6 +38,7 @@ import com.google.common.reflect.TypeToken; * async interface will be removed in jclouds 1.7. */ @Beta +@Deprecated public abstract class BaseRestApiMetadata extends BaseApiMetadata implements RestApiMetadata { protected final Class<?> api; http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/project/pom.xml ---------------------------------------------------------------------- diff --git a/project/pom.xml b/project/pom.xml index 42842bb..5848c05 100644 --- a/project/pom.xml +++ b/project/pom.xml @@ -602,6 +602,15 @@ <encoding>${project.build.sourceEncoding}</encoding> <source>${maven.compile.source}</source> <target>${maven.compile.target}</target> + <showDeprecation>false</showDeprecation> + <showWarnings>true</showWarnings> + <compilerArguments> + <Xlint /> + <Xlint:-deprecation /> + <Xlint:-rawtypes /> + <Xlint:-serial /> + <Xlint:-unchecked /> + </compilerArguments> </configuration> </plugin> <plugin> http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3AsyncClient.java ---------------------------------------------------------------------- diff --git a/providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3AsyncClient.java b/providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3AsyncClient.java index 366c2ef..50ae143 100644 --- a/providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3AsyncClient.java +++ b/providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3AsyncClient.java @@ -70,6 +70,7 @@ import com.google.common.util.concurrent.ListenableFuture; */ @RequestFilters(RequestAuthorizeSignature.class) @BlobScope(CONTAINER) +@Deprecated public interface AWSS3AsyncClient extends S3AsyncClient { /** http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d8490f87/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/handlers/UltraDNSWSErrorHandler.java ---------------------------------------------------------------------- diff --git a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/handlers/UltraDNSWSErrorHandler.java b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/handlers/UltraDNSWSErrorHandler.java index d2953ed..b5800ca 100644 --- a/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/handlers/UltraDNSWSErrorHandler.java +++ b/providers/ultradns-ws/src/main/java/org/jclouds/ultradns/ws/handlers/UltraDNSWSErrorHandler.java @@ -139,6 +139,7 @@ public class UltraDNSWSErrorHandler implements HttpErrorHandler { return exception; if (exception.getError().getDescription().get().indexOf("Cannot find") == -1) return exception; + return new ResourceNotFoundException(message, exception); case ErrorCodes.ZONE_NOT_FOUND: case ErrorCodes.RESOURCE_RECORD_NOT_FOUND: case ErrorCodes.ACCOUNT_NOT_FOUND:
