(jena) branch main updated: SPARQL syntax tests - better info on test failure

[andy]

This is an automated email from the ASF dual-hosted git repository.

andy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/jena.git


The following commit(s) were added to refs/heads/main by this push:
     new 319c8191fc SPARQL syntax tests - better info on test failure
319c8191fc is described below

commit 319c8191fcd0683686ec536334f100673491f5a4
Author: Andy Seaborne <a...@apache.org>
AuthorDate: Sun Dec 14 11:26:05 2025 +0000

    SPARQL syntax tests - better info on test failure
---
 .../src/test/java/org/apache/jena/arq/junit/manifest/Manifest.java   | 5 -----
 .../java/org/apache/jena/arq/junit/sparql/tests/QuerySyntaxTest.java | 5 +++--
 .../org/apache/jena/arq/junit/sparql/tests/UpdateSyntaxTest.java     | 5 +++--
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git 
a/jena-arq/src/test/java/org/apache/jena/arq/junit/manifest/Manifest.java 
b/jena-arq/src/test/java/org/apache/jena/arq/junit/manifest/Manifest.java
index ad76bd0481..f35a19291a 100644
--- a/jena-arq/src/test/java/org/apache/jena/arq/junit/manifest/Manifest.java
+++ b/jena-arq/src/test/java/org/apache/jena/arq/junit/manifest/Manifest.java
@@ -55,11 +55,6 @@ public class Manifest
         // Exceptions from @TestFactories are swallowed by JUnit5.
         try {
             manifestRDF = RDFParser.source(filenameOrURI).toGraph();
-        } catch (RiotNotFoundException ex) {
-            log.error("Not found: "+filenameOrURI);
-            // Exit on error.
-            System.exit(1);
-            throw new RiotNotFoundException("Manifest "+filenameOrURI);
         } catch (RiotException ex) {
             // Exit on error.
             log.error("Error reading manifest: "+filenameOrURI);
diff --git 
a/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/QuerySyntaxTest.java
 
b/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/QuerySyntaxTest.java
index 7c0a2410ae..631b215409 100644
--- 
a/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/QuerySyntaxTest.java
+++ 
b/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/QuerySyntaxTest.java
@@ -23,6 +23,7 @@ import static org.junit.jupiter.api.Assertions.fail;
 import org.apache.jena.arq.junit.LibTest;
 import org.apache.jena.arq.junit.manifest.AbstractManifestTest;
 import org.apache.jena.arq.junit.manifest.ManifestEntry;
+import org.apache.jena.atlas.lib.FileOps;
 import org.apache.jena.query.Query;
 
 //import java.io.IOException;
@@ -47,14 +48,14 @@ public class QuerySyntaxTest extends AbstractManifestTest {
             Query query = SparqlTestLib.queryFromEntry(manifestEntry, 
testSyntax);
             if ( !expectLegalSyntax ) {
                 String filename = SparqlTestLib.getAction(manifestEntry);
-                System.out.printf("==== %s\n", "Negative syntax test");
+                System.out.printf("==== Syntax test %s : %s\n", 
FileOps.basename(filename), "expected negative, got positive");
                 LibTest.printFile(filename);
                 fail("Expected parse failure");
             }
         } catch (QueryException qEx) {
             if ( expectLegalSyntax ) {
                 String filename = SparqlTestLib.getAction(manifestEntry);
-                System.out.printf("==== %s\n", "Positive syntax test");
+                System.out.printf("==== Syntax test %s : %s\n", 
FileOps.basename(filename), "expected postive, got negative");
                 LibTest.printFile(filename);
                 throw qEx;
             }
diff --git 
a/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/UpdateSyntaxTest.java
 
b/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/UpdateSyntaxTest.java
index e74e6f697d..f2c04083cf 100644
--- 
a/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/UpdateSyntaxTest.java
+++ 
b/jena-arq/src/test/java/org/apache/jena/arq/junit/sparql/tests/UpdateSyntaxTest.java
@@ -23,6 +23,7 @@ import static org.junit.jupiter.api.Assertions.fail;
 import org.apache.jena.arq.junit.LibTest;
 import org.apache.jena.arq.junit.manifest.AbstractManifestTest;
 import org.apache.jena.arq.junit.manifest.ManifestEntry;
+import org.apache.jena.atlas.lib.FileOps;
 import org.apache.jena.query.Syntax;
 
 public class UpdateSyntaxTest extends AbstractManifestTest {
@@ -41,14 +42,14 @@ public class UpdateSyntaxTest extends AbstractManifestTest {
             SparqlTestLib.updateFromEntry(manifestEntry, testSyntax) ;
             if ( ! expectLegalSyntax ) {
                 String filename = SparqlTestLib.getAction(manifestEntry);
-                System.out.printf("==== %s\n", "Negative update syntax test");
+                System.out.printf("==== Syntax test %s : %s\n", 
FileOps.basename(filename), "expected negative, got positive");
                 LibTest.printFile(filename);
                 fail("Expected parse failure");
             }
         } catch (RuntimeException ex) {
             if ( expectLegalSyntax ) {
                 String filename = SparqlTestLib.getAction(manifestEntry);
-                System.out.printf("==== %s\n", "Positive update syntax test");
+                System.out.printf("==== Syntax test %s : %s\n", 
FileOps.basename(filename), "expected positive, got negative");
                 LibTest.printFile(filename);
                 throw ex;
             }