This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/jmeter.git
commit 13b824a5a99bf14789a434ddf1e13b11bfd04573 Author: Vladimir Sitnikov <[email protected]> AuthorDate: Wed Dec 27 08:28:06 2023 +0300 test: ensure all Gui elements initialize non-empty TestElement names --- .../src/test/java/org/apache/jmeter/junit/JMeterTest.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java b/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java index 3ed11e88c1..f442cb64dc 100644 --- a/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java +++ b/src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java @@ -47,6 +47,7 @@ import javax.xml.parsers.ParserConfigurationException; import org.apache.commons.lang3.StringUtils; import org.apache.jmeter.config.gui.ObsoleteGui; +import org.apache.jmeter.control.gui.TestFragmentControllerGui; import org.apache.jmeter.dsl.DslPrinterTraverser; import org.apache.jmeter.gui.JMeterGUIComponent; import org.apache.jmeter.gui.UnsharedComponent; @@ -374,8 +375,14 @@ public class JMeterTest extends JMeterTestCaseJUnit implements Describable { assertEquals("GUI-CLASS: Failed on " + name, name, el.getPropertyAsString(TestElement.GUI_CLASS)); assertEquals("NAME: Failed on " + name, guiItem.getName(), el.getName()); + if (StringUtils.isEmpty(el.getName())) { + fail("Name of the element must not be blank. Gui class " + name + ", element class " + el.getClass().getName()); + } assertEquals("TEST-CLASS: Failed on " + name, el.getClass().getName(), el .getPropertyAsString(TestElement.TEST_CLASS)); + if (guiItem.getClass() != TestFragmentControllerGui.class) { + assertTrue("Should be enabled by default: " + name, el.isEnabled()); + } TestElement el2 = guiItem.createTestElement(); el.setName("hey, new name!:"); el.setProperty("NOT", "Shouldn't be here");
