This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new db7ba92112 SonarQube bug fixes
db7ba92112 is described below
commit db7ba921124d63b6d246b7cdce2c6f78ca1bea27
Author: James Bognar <[email protected]>
AuthorDate: Wed Feb 4 16:38:06 2026 -0500
SonarQube bug fixes
---
.../main/java/org/apache/juneau/bean/atom/package.html | 1 +
.../java/org/apache/juneau/bean/html5/package2.html | 1 +
.../apache/juneau/examples/rest/RootResourcesTest.java | 1 +
.../juneau/microservice/resources/ConfigEdit.html | 1 +
.../juneau/a/rttests/RoundTripLargeObjects_Test.java | 7 +++++++
.../juneau/commons/io/NoCloseOutputStream_Test.java | 18 ++++++++++--------
.../apache/juneau/commons/io/NoCloseWriter_Test.java | 18 ++++++++++--------
.../apache/juneau/commons/reflect/ClassInfo_Test.java | 6 ++----
.../apache/juneau/commons/reflect/MethodInfo_Test.java | 9 +++------
.../juneau/commons/utils/CollectionUtils_Test.java | 10 ----------
.../juneau/commons/utils/PredicateUtils_Test.java | 10 ----------
.../org/apache/juneau/commons/utils/Utils_Test.java | 6 ++++--
.../org/apache/juneau/rest/client/RestClient_Test.java | 4 ++--
13 files changed, 42 insertions(+), 50 deletions(-)
diff --git
a/juneau-bean/juneau-bean-atom/src/main/java/org/apache/juneau/bean/atom/package.html
b/juneau-bean/juneau-bean-atom/src/main/java/org/apache/juneau/bean/atom/package.html
index 723bae5ddc..2e7b1355c4 100644
---
a/juneau-bean/juneau-bean-atom/src/main/java/org/apache/juneau/bean/atom/package.html
+++
b/juneau-bean/juneau-bean-atom/src/main/java/org/apache/juneau/bean/atom/package.html
@@ -16,6 +16,7 @@
-->
<html lang="en" xml:lang="en">
<head>
+ <title>ATOM Package</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style type="text/css">
/* For viewing in Page Designer */
diff --git
a/juneau-bean/juneau-bean-html5/src/main/java/org/apache/juneau/bean/html5/package2.html
b/juneau-bean/juneau-bean-html5/src/main/java/org/apache/juneau/bean/html5/package2.html
index dd40c2d37d..5d027cd443 100644
---
a/juneau-bean/juneau-bean-html5/src/main/java/org/apache/juneau/bean/html5/package2.html
+++
b/juneau-bean/juneau-bean-html5/src/main/java/org/apache/juneau/bean/html5/package2.html
@@ -16,6 +16,7 @@
-->
<html lang="en" xml:lang="en">
<head>
+ <title>HTML5 Package</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style type="text/css">
/* For viewing in Page Designer */
diff --git
a/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
b/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
index d5ecca3e7e..7d580d91cd 100644
---
a/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
+++
b/juneau-examples/juneau-examples-rest-jetty-ftest/src/test/java/org/apache/juneau/examples/rest/RootResourcesTest.java
@@ -97,6 +97,7 @@ public class RootResourcesTest extends RestTestcase {
public void testJsonSchema() throws Exception {
try (RestClient client =
SamplesMicroservice.client().parsers(JsonParser.DEFAULT).accept("text/json+schema").build())
{
var m =
client.get("").run().getContent().as(JsonMap.class);
+ assertNotNull(m);
if (debug)
System.err.println(m);
client.closeQuietly();
diff --git
a/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/ConfigEdit.html
b/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/ConfigEdit.html
index 0c62e205da..3bcc54bf15 100755
---
a/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/ConfigEdit.html
+++
b/juneau-microservice/juneau-microservice-core/src/main/java/org/apache/juneau/microservice/resources/ConfigEdit.html
@@ -16,6 +16,7 @@
-->
<html lang="en" xml:lang="en">
<head>
+ <title>Configuration Editor</title>
<meta http-equiv='Content-Type' content='text/html; charset=UTF-8'>
<style type='text/css'>
@import '$R{servletURI}/style.css';
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripLargeObjects_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripLargeObjects_Test.java
index 8c9ebf1e09..d4a5b34e1e 100755
---
a/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripLargeObjects_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/a/rttests/RoundTripLargeObjects_Test.java
@@ -17,6 +17,7 @@
package org.apache.juneau.a.rttests;
import static org.apache.juneau.commons.utils.Utils.*;
+import static org.junit.jupiter.api.Assertions.*;
import java.util.*;
@@ -122,6 +123,12 @@ class RoundTripLargeObjects_Test extends TestBase {
for (var i = 0; i < numRuns; i++)
p.parse(r, A.class);
System.err.println(f("Average parsed time: {0,number}ms",
(System.currentTimeMillis()-startTime)/numRuns)); // NOT DEBUG
+ // Verify round-trip correctness
+ var parsed = p.parse(r, A.class);
+ assertNotNull(parsed);
+ assertEquals(a.a1Map.size(), parsed.a1Map.size());
+ assertEquals(a.a1List.size(), parsed.a1List.size());
+ assertEquals(a.a1Array.length, parsed.a1Array.length);
}
public static class A {
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseOutputStream_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseOutputStream_Test.java
index 0d93323e7c..ff8b6a6405 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseOutputStream_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseOutputStream_Test.java
@@ -65,10 +65,11 @@ class NoCloseOutputStream_Test extends TestBase {
@Test void b02_flush_multipleTimes() throws IOException {
var baos = new ByteArrayOutputStream();
var wrapper = new NoCloseOutputStream(baos);
- wrapper.flush();
- wrapper.flush();
- wrapper.flush();
- // Should not throw
+ assertDoesNotThrow(() -> {
+ wrapper.flush();
+ wrapper.flush();
+ wrapper.flush();
+ });
}
//====================================================================================================
@@ -96,10 +97,11 @@ class NoCloseOutputStream_Test extends TestBase {
@Test void c03_close_multipleTimes() throws IOException {
var baos = new ByteArrayOutputStream();
var wrapper = new NoCloseOutputStream(baos);
- wrapper.close();
- wrapper.close();
- wrapper.close();
- // Should not throw
+ assertDoesNotThrow(() -> {
+ wrapper.close();
+ wrapper.close();
+ wrapper.close();
+ });
}
//====================================================================================================
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseWriter_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseWriter_Test.java
index fb640dfeee..fa1255f71c 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseWriter_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/io/NoCloseWriter_Test.java
@@ -113,10 +113,11 @@ class NoCloseWriter_Test extends TestBase {
@Test void c02_flush_multipleTimes() throws IOException {
var sw = new StringWriter();
var wrapper = new NoCloseWriter(sw);
- wrapper.flush();
- wrapper.flush();
- wrapper.flush();
- // Should not throw
+ assertDoesNotThrow(() -> {
+ wrapper.flush();
+ wrapper.flush();
+ wrapper.flush();
+ });
}
//====================================================================================================
@@ -144,10 +145,11 @@ class NoCloseWriter_Test extends TestBase {
@Test void d03_close_multipleTimes() throws IOException {
var sw = new StringWriter();
var wrapper = new NoCloseWriter(sw);
- wrapper.close();
- wrapper.close();
- wrapper.close();
- // Should not throw
+ assertDoesNotThrow(() -> {
+ wrapper.close();
+ wrapper.close();
+ wrapper.close();
+ });
}
//====================================================================================================
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ClassInfo_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ClassInfo_Test.java
index 66de7d5567..af755cca3e 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ClassInfo_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ClassInfo_Test.java
@@ -4129,9 +4129,8 @@ public class ClassInfo_Test extends TestBase {
}
}
var bean = new ConcreteMethodInjection();
- ClassInfo.of(bean).inject(bean, beanStore);
+ assertDoesNotThrow(() -> ClassInfo.of(bean).inject(bean,
beanStore));
// Abstract method should be skipped (not called)
- // Should complete without error
}
@Test
@@ -4166,8 +4165,7 @@ public class ClassInfo_Test extends TestBase {
beanStore.addBean(TestService.class, service1, "service1"); //
Required for method8
var bean = new TestMethodInjection();
// Static methods should be called (with null instance)
- // Just verify no exception is thrown
- ClassInfo.of(bean).inject(bean, beanStore);
+ assertDoesNotThrow(() -> ClassInfo.of(bean).inject(bean,
beanStore));
// Method should execute without error (can't check instance
field from static method)
}
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
index d496e9fae1..2d344a1e8d 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
@@ -950,8 +950,7 @@ class MethodInfo_Test extends TestBase {
beanStore.addBean(TestService.class, service);
var instance = new TestMethodClass();
var method =
ClassInfo.of(TestMethodClass.class).getPublicMethod(x -> x.hasName("method1")
&& x.hasParameterTypes(TestService.class)).get();
- method.inject(beanStore, instance);
- // Method should execute without exception
+ assertDoesNotThrow(() -> method.inject(beanStore, instance));
}
@Test
@@ -959,8 +958,7 @@ class MethodInfo_Test extends TestBase {
var service = new TestService("test1");
beanStore.addBean(TestService.class, service);
var method =
ClassInfo.of(TestMethodClass.class).getPublicMethod(x ->
x.hasName("staticMethod") && x.hasParameterTypes(TestService.class)).get();
- method.inject(beanStore, null); // null for static methods
- // Method should execute without exception
+ assertDoesNotThrow(() -> method.inject(beanStore, null)); //
null for static methods
}
//====================================================================================================
@@ -973,8 +971,7 @@ class MethodInfo_Test extends TestBase {
// Service not in bean store, but provided as otherBeans
var instance = new TestMethodClass();
var method =
ClassInfo.of(TestMethodClass.class).getPublicMethod(x -> x.hasName("method1")
&& x.hasParameterTypes(TestService.class)).get();
- method.inject(beanStore, instance, service);
- // Method should execute without exception
+ assertDoesNotThrow(() -> method.inject(beanStore, instance,
service));
}
@Test
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/utils/CollectionUtils_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/utils/CollectionUtils_Test.java
index be2df6d944..b4efca5a43 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/utils/CollectionUtils_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/utils/CollectionUtils_Test.java
@@ -29,16 +29,6 @@ import org.junit.jupiter.api.*;
class CollectionUtils_Test extends TestBase {
-
//====================================================================================================
- // Constructor (line 126)
-
//====================================================================================================
- @Test
- void a00_constructor() {
- // Test line 126: class instantiation
- // CollectionUtils has a private constructor, so it cannot be
instantiated.
- // Line 126 (class declaration) is covered by using the class's
static methods.
- }
-
//====================================================================================================
// a(T...)
//====================================================================================================
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/utils/PredicateUtils_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/utils/PredicateUtils_Test.java
index 31bc96fe2b..a9035bb441 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/utils/PredicateUtils_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/utils/PredicateUtils_Test.java
@@ -29,16 +29,6 @@ import org.junit.jupiter.api.*;
@SuppressWarnings("java:S5961")
class PredicateUtils_Test {
-
//====================================================================================================
- // Constructor (line 24)
-
//====================================================================================================
- @Test
- void a00_constructor() {
- // Test line 24: class declaration
- // PredicateUtils has a private constructor, so it cannot be
instantiated.
- // Line 24 (class declaration) is covered by using the class's
static methods.
- }
-
//====================================================================================================
// consumeIf(Predicate<T>, Consumer<T>, T)
//====================================================================================================
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/utils/Utils_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/utils/Utils_Test.java
index b01c21aee0..f15dc7d0cd 100644
--- a/juneau-utest/src/test/java/org/apache/juneau/commons/utils/Utils_Test.java
+++ b/juneau-utest/src/test/java/org/apache/juneau/commons/utils/Utils_Test.java
@@ -806,8 +806,10 @@ class Utils_Test extends TestBase {
@Test
void a045_printLines() {
// This test just verifies the method doesn't throw
- printLines(a("Line 1", "Line 2", "Line 3"));
- printLines(a());
+ assertDoesNotThrow(() -> {
+ printLines(a("Line 1", "Line 2", "Line 3"));
+ printLines(a());
+ });
}
//====================================================================================================
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Test.java
index 8fba1101e6..4484a467a5 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Test.java
@@ -388,8 +388,8 @@ class RestClient_Test extends TestBase {
@Test void e13_httpMessage_removeHeader() throws Exception {
var x = client().build().get("/bean");
x.setHeaders(a(header("Foo","bar")));
- x.removeHeader(header("Foo","bar"));
- //assertNull(x.getFirstHeader("Foo")); // Bug in HttpClient
API?
+ assertDoesNotThrow(() -> x.removeHeader(header("Foo","bar")));
+ // Note: assertNull(x.getFirstHeader("Foo")) fails due to
HttpClient API behavior
}
@Test void e14_httpMessage_headerIterator() throws Exception {
