This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new db1ea2091a SonarQube bug fixes
db1ea2091a is described below
commit db1ea2091a7a1f8b8ef479d59890577db77389e6
Author: James Bognar <[email protected]>
AuthorDate: Thu Feb 5 16:38:31 2026 -0500
SonarQube bug fixes
---
.../src/main/java/org/apache/juneau/assertions/Assertion.java | 1 +
.../src/main/java/org/apache/juneau/assertions/AssertionPredicate.java | 1 +
.../main/java/org/apache/juneau/assertions/FluentBooleanAssertion.java | 1 +
.../java/org/apache/juneau/assertions/FluentCollectionAssertion.java | 1 +
.../src/main/java/org/apache/juneau/assertions/FluentListAssertion.java | 1 +
.../src/main/java/org/apache/juneau/assertions/FluentMapAssertion.java | 1 +
.../src/main/java/org/apache/juneau/assertions/Verify.java | 1 +
.../src/main/java/org/apache/juneau/commons/logging/LogRecord.java | 1 +
.../src/main/java/org/apache/juneau/commons/settings/Settings.java | 2 +-
.../src/main/java/org/apache/juneau/parser/ParserReader.java | 2 +-
.../java/org/apache/juneau/microservice/jetty/JettyMicroservice.java | 1 +
.../juneau/rest/client/assertion/FluentResponseBodyAssertion.java | 1 +
.../apache/juneau/rest/assertions/FluentRequestContentAssertion.java | 1 +
.../src/main/java/org/apache/juneau/rest/servlet/RestServlet.java | 1 +
.../test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java | 2 +-
.../test/java/org/apache/juneau/commons/reflect/ParameterInfo_Test.java | 2 +-
16 files changed, 16 insertions(+), 4 deletions(-)
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Assertion.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Assertion.java
index 94a779d3dc..b163b0c956 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Assertion.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Assertion.java
@@ -58,6 +58,7 @@ import org.apache.juneau.cp.*;
* <li class='link'><a class="doclink"
href="https://juneau.apache.org/docs/topics/JuneauEcosystemOverview";>Juneau
Ecosystem Overview</a>
* </ul>
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_parameterCannotBeNull)
public class Assertion {
private static final Messages MESSAGES = Messages.of(Assertion.class,
"Messages");
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/AssertionPredicate.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/AssertionPredicate.java
index 1d58db41a9..c738994ed4 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/AssertionPredicate.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/AssertionPredicate.java
@@ -59,6 +59,7 @@ import org.apache.juneau.cp.*;
*
* @param <T> the type of input being tested.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_predicateTestFailed, MSG_valueDidNotPassTest)
public class AssertionPredicate<T> implements Predicate<T> {
/**
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentBooleanAssertion.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentBooleanAssertion.java
index 77746a2c8a..cab705eabf 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentBooleanAssertion.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentBooleanAssertion.java
@@ -96,6 +96,7 @@ import org.apache.juneau.serializer.*;
*
* @param <R> The return type.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_valueWasFalse)
public class FluentBooleanAssertion<R> extends
FluentComparableAssertion<Boolean,R> {
private static final Messages MESSAGES =
Messages.of(FluentBooleanAssertion.class, "Messages");
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentCollectionAssertion.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentCollectionAssertion.java
index 2e21e7f104..9739cfb385 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentCollectionAssertion.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentCollectionAssertion.java
@@ -103,6 +103,7 @@ import org.apache.juneau.serializer.*;
* @param <E> The element type.
* @param <R> The return type.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_collectionWasNotEmpty)
public class FluentCollectionAssertion<E,R> extends
FluentObjectAssertion<Collection<E>,R> {
private static final Messages MESSAGES =
Messages.of(FluentCollectionAssertion.class, "Messages");
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentListAssertion.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentListAssertion.java
index e83c9ed0c3..79ae46aa6e 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentListAssertion.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentListAssertion.java
@@ -119,6 +119,7 @@ import org.apache.juneau.serializer.*;
* @param <E> The element type.
* @param <R> The return type.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_listDidNotContainExpectedValueAt)
public class FluentListAssertion<E,R> extends FluentCollectionAssertion<E,R> {
// @formatter:off
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentMapAssertion.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentMapAssertion.java
index f501c7e27e..75c9a49b57 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentMapAssertion.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/FluentMapAssertion.java
@@ -107,6 +107,7 @@ import org.apache.juneau.serializer.*;
* @param <V> The value type.
* @param <R> The return type.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_mapWasNotEmpty)
public class FluentMapAssertion<K,V,R> extends
FluentObjectAssertion<Map<K,V>,R> {
private static final Messages MESSAGES =
Messages.of(FluentMapAssertion.class, "Messages");
diff --git
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Verify.java
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Verify.java
index 14ef982328..740efdbeba 100644
---
a/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Verify.java
+++
b/juneau-core/juneau-assertions/src/main/java/org/apache/juneau/assertions/Verify.java
@@ -41,6 +41,7 @@ import org.apache.juneau.cp.*;
* <li class='link'><a class="doclink"
href="https://juneau.apache.org/docs/topics/JuneauEcosystemOverview";>Juneau
Ecosystem Overview</a>
* </ul>
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_unexpectedType)
public class Verify {
private static final Messages MESSAGES = Messages.of(Verify.class,
"Messages");
diff --git
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/logging/LogRecord.java
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/logging/LogRecord.java
index 0ccd2bc5bc..10b6bce516 100644
---
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/logging/LogRecord.java
+++
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/logging/LogRecord.java
@@ -48,6 +48,7 @@ import org.apache.juneau.commons.utils.*;
* <li class='jc'>{@link java.util.logging.LogRecord}
* </ul>
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., KEY_date)
public class LogRecord extends java.util.logging.LogRecord {
private static final long serialVersionUID = 1L;
diff --git
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/settings/Settings.java
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/settings/Settings.java
index fb6d3ab0f1..74f601d4ac 100644
---
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/settings/Settings.java
+++
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/settings/Settings.java
@@ -129,7 +129,7 @@ import org.apache.juneau.commons.reflect.*;
* </p>
* </ul>
*/
-@SuppressWarnings("java:S115")
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., ARG_sources, MSG_globalDisabled)
public class Settings {
// Argument name constants for assertArgNoNulls
diff --git
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
index 3f8698300d..0b89c0838d 100644
---
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
+++
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/ParserReader.java
@@ -42,7 +42,7 @@ import org.apache.juneau.commons.io.*;
* </ul>
*/
-@SuppressWarnings("resource")
+@SuppressWarnings({ "resource", "java:S115" }) // Constants use
UPPER_snakeCase convention (e.g., MSG_bufferUnderflow)
public class ParserReader extends Reader implements Positionable {
// Error message constants
diff --git
a/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
b/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
index 29d00233b9..8333e560f0 100644
---
a/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
+++
b/juneau-microservice/juneau-microservice-jetty/src/main/java/org/apache/juneau/microservice/jetty/JettyMicroservice.java
@@ -62,6 +62,7 @@ import jakarta.servlet.*;
* <li class='link'><a class="doclink"
href="https://juneau.apache.org/docs/topics/JuneauMicroserviceJettyBasics";>juneau-microservice-jetty
Basics</a>
* </ul>
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., KEY_SERVLET_CONTEXT_HANDLER)
public class JettyMicroservice extends Microservice {
/**
diff --git
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/assertion/FluentResponseBodyAssertion.java
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/assertion/FluentResponseBodyAssertion.java
index 2115b89e18..8a10e0800b 100644
---
a/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/assertion/FluentResponseBodyAssertion.java
+++
b/juneau-rest/juneau-rest-client/src/main/java/org/apache/juneau/rest/client/assertion/FluentResponseBodyAssertion.java
@@ -102,6 +102,7 @@ import org.apache.juneau.serializer.*;
*
* @param <R> The return type.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_exceptionDuringCall)
public class FluentResponseBodyAssertion<R> extends
FluentObjectAssertion<ResponseContent,R> {
// Error message constants
diff --git
a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/assertions/FluentRequestContentAssertion.java
b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/assertions/FluentRequestContentAssertion.java
index 02f4f62c2f..f85ca723a1 100644
---
a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/assertions/FluentRequestContentAssertion.java
+++
b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/assertions/FluentRequestContentAssertion.java
@@ -101,6 +101,7 @@ import org.apache.juneau.serializer.*;
*
* @param <R> The return type.
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_exceptionDuringCall)
public class FluentRequestContentAssertion<R> extends
FluentObjectAssertion<RequestContent,R> {
// Error message constants
diff --git
a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/servlet/RestServlet.java
b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/servlet/RestServlet.java
index 869228eb2b..a134d3b3bd 100644
---
a/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/servlet/RestServlet.java
+++
b/juneau-rest/juneau-rest-server/src/main/java/org/apache/juneau/rest/servlet/RestServlet.java
@@ -63,6 +63,7 @@ import jakarta.servlet.http.*;
*
* @serial exclude
*/
+@SuppressWarnings("java:S115") // Constants use UPPER_snakeCase convention
(e.g., MSG_servletInitError)
public abstract class RestServlet extends HttpServlet {
private static final long serialVersionUID = 1L;
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
index a9aeae9bbc..b9d2992b69 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/MethodInfo_Test.java
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.*;
import static org.apache.juneau.commons.utils.Utils.*;
-@SuppressWarnings("java:S1186")
+@SuppressWarnings({ "java:S1186", "java:S116" }) // Field names use
underscores for test data (e.g., a_m, c_a1)
class MethodInfo_Test extends TestBase {
@Documented
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ParameterInfo_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ParameterInfo_Test.java
index 06c29aafe8..3629be3ca3 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ParameterInfo_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/commons/reflect/ParameterInfo_Test.java
@@ -32,7 +32,7 @@ import org.apache.juneau.*;
import org.apache.juneau.annotation.Name;
import org.junit.jupiter.api.*;
-@SuppressWarnings({"java:S117", "java:S5961", "java:S1186"})
+@SuppressWarnings({ "java:S117", "java:S5961", "java:S1186", "java:S116" }) //
Field names use underscores for test data (e.g., b_a1_a, b_b_a)
class ParameterInfo_Test extends TestBase {
private static String originalDisableParamNameDetection;
