This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/master by this push:
new 0a67125110 SonarQube bug fixes
0a67125110 is described below
commit 0a671251105e1689e6cc657d9baff0e5eec1f0c2
Author: James Bognar <[email protected]>
AuthorDate: Fri Feb 6 09:57:52 2026 -0500
SonarQube bug fixes
---
.../src/main/java/org/apache/juneau/commons/collections/HashKey.java | 2 +-
.../src/main/java/org/apache/juneau/commons/reflect/ClassInfo.java | 2 +-
.../juneau-marshall/src/main/java/org/apache/juneau/parser/Parser.java | 1 +
.../src/main/java/org/apache/juneau/serializer/Serializer.java | 1 +
.../apache/juneau/rest/client/RestClient_Response_Headers_Test.java | 3 ++-
5 files changed, 6 insertions(+), 3 deletions(-)
diff --git
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/collections/HashKey.java
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/collections/HashKey.java
index 910eaee1de..150d1425e8 100644
---
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/collections/HashKey.java
+++
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/collections/HashKey.java
@@ -152,7 +152,7 @@ public class HashKey {
*/
@Override
public boolean equals(Object o) {
- if (o == null || !(o instanceof HashKey))
+ if (!(o instanceof HashKey))
return false;
var x = (HashKey)o;
if (array.length != x.array.length)
diff --git
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/reflect/ClassInfo.java
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/reflect/ClassInfo.java
index 43820c0ec3..8ee502aff1 100644
---
a/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/reflect/ClassInfo.java
+++
b/juneau-core/juneau-commons/src/main/java/org/apache/juneau/commons/reflect/ClassInfo.java
@@ -78,7 +78,7 @@ public class ClassInfo extends ElementInfo implements
Annotatable, Type, Compara
private static final Cache<Class,ClassInfoTyped> CACHE =
Cache.of(Class.class, ClassInfoTyped.class).build();
- /** Reusable ClassInfo for Object class. */
+ /** Reusable cached ClassInfo instance for Object.class. */
public static final ClassInfo OBJECT = ClassInfo.of(Object.class);
private static final Map<Class<?>,Class<?>> pmap1 = new HashMap<>();
diff --git
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/Parser.java
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/Parser.java
index 061b16cac4..e2e6e8a74a 100644
---
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/Parser.java
+++
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/parser/Parser.java
@@ -970,6 +970,7 @@ public class Parser extends BeanContextable {
* Represents no Parser.
*/
public abstract static class Null extends Parser {
+ @SuppressWarnings("java:S1186") // Constructor required by
Parser parent class, even though Null is abstract and never instantiated
directly
private Null(Builder builder) {
super(builder);
}
diff --git
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/serializer/Serializer.java
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/serializer/Serializer.java
index a714f3dc32..9203553c95 100644
---
a/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/serializer/Serializer.java
+++
b/juneau-core/juneau-marshall/src/main/java/org/apache/juneau/serializer/Serializer.java
@@ -1266,6 +1266,7 @@ public class Serializer extends BeanTraverseContext {
* Represents no Serializer.
*/
public abstract static class Null extends Serializer {
+ @SuppressWarnings("java:S1186") // Constructor required by
Serializer parent class, even though Null is abstract and never instantiated
directly
private Null(Builder builder) {
super(builder);
}
diff --git
a/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Response_Headers_Test.java
b/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Response_Headers_Test.java
index 66e7ef9eaf..93ee62cda1 100644
---
a/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Response_Headers_Test.java
+++
b/juneau-utest/src/test/java/org/apache/juneau/rest/client/RestClient_Response_Headers_Test.java
@@ -62,8 +62,9 @@ class RestClient_Response_Headers_Test extends TestBase {
public static class A2 extends BasicHeader {
private static final long serialVersionUID = 1L;
+ @SuppressWarnings("java:S1186") // Constructor required by
BasicHeader parent class, even though never explicitly called
private A2(String name, Object value) {
- super(name, value); // Never called.
+ super(name, value);
}
}
