Repository: kafka Updated Branches: refs/heads/trunk bde49e371 -> ba6f141dd
MINOR: Tiny optimization to avoid mapping twice on the results. As pointed out by granthenke in #196, error can be wrapped in JShort directly to avoid second map. Author: David Jacot <[email protected]> Reviewers: Grant Henke, Gwen Shapira Closes #714 from dajac/wrap-jshort Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/ba6f141d Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/ba6f141d Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/ba6f141d Branch: refs/heads/trunk Commit: ba6f141dd78b3dfeafb2088f8acb6dcf65468b19 Parents: bde49e3 Author: David Jacot <[email protected]> Authored: Tue Dec 22 17:55:13 2015 -0800 Committer: Gwen Shapira <[email protected]> Committed: Tue Dec 22 17:55:13 2015 -0800 ---------------------------------------------------------------------- core/src/main/scala/kafka/server/KafkaApis.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/ba6f141d/core/src/main/scala/kafka/server/KafkaApis.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala b/core/src/main/scala/kafka/server/KafkaApis.scala index 5a3b8af..8589400 100644 --- a/core/src/main/scala/kafka/server/KafkaApis.scala +++ b/core/src/main/scala/kafka/server/KafkaApis.scala @@ -136,8 +136,8 @@ class KafkaApis(val requestChannel: RequestChannel, val result = replicaManager.becomeLeaderOrFollower(correlationId, leaderAndIsrRequest, metadataCache, onLeadershipChange) new LeaderAndIsrResponse(result.errorCode, result.responseMap.mapValues(new JShort(_)).asJava) } else { - val result = leaderAndIsrRequest.partitionStates.asScala.keys.map((_, Errors.CLUSTER_AUTHORIZATION_FAILED.code)).toMap - new LeaderAndIsrResponse(Errors.CLUSTER_AUTHORIZATION_FAILED.code, result.mapValues(new JShort(_)).asJava) + val result = leaderAndIsrRequest.partitionStates.asScala.keys.map((_, new JShort(Errors.CLUSTER_AUTHORIZATION_FAILED.code))).toMap + new LeaderAndIsrResponse(Errors.CLUSTER_AUTHORIZATION_FAILED.code, result.asJava) } requestChannel.sendResponse(new Response(request, new ResponseSend(request.connectionId, responseHeader, leaderAndIsrResponse)))
