Repository: kafka Updated Branches: refs/heads/trunk cb78223bf -> 419e268d6
KAFKA-3445: Validate TASKS_MAX_CONFIG's lower bound Currently the property TASKS_MAX_CONFIG is not validated against nonsensical values such as 0. This patch leverages the Range.atLeast() method to ensure value is at least 1. Author: Ryan P <[email protected]> Reviewers: Ewen Cheslack-Postava <[email protected]> Closes #1132 from rnpridgeon/KAFKA-3445 Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/419e268d Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/419e268d Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/419e268d Branch: refs/heads/trunk Commit: 419e268d6fe9695e31e9be299c99573522a81dd0 Parents: cb78223 Author: Ryan P <[email protected]> Authored: Thu Mar 24 10:12:19 2016 -0700 Committer: Ewen Cheslack-Postava <[email protected]> Committed: Thu Mar 24 10:12:19 2016 -0700 ---------------------------------------------------------------------- .../java/org/apache/kafka/connect/runtime/ConnectorConfig.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/419e268d/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ---------------------------------------------------------------------- diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java index e21faf6..e439552 100644 --- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java +++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java @@ -22,6 +22,8 @@ import org.apache.kafka.common.config.ConfigDef; import org.apache.kafka.common.config.ConfigDef.Importance; import org.apache.kafka.common.config.ConfigDef.Type; import org.apache.kafka.common.config.ConfigDef.Width; +import static org.apache.kafka.common.config.ConfigDef.Range.atLeast; + import java.util.HashMap; import java.util.Map; @@ -54,6 +56,8 @@ public class ConnectorConfig extends AbstractConfig { public static final String TASKS_MAX_CONFIG = "tasks.max"; private static final String TASKS_MAX_DOC = "Maximum number of tasks to use for this connector."; public static final int TASKS_MAX_DEFAULT = 1; + private static final int TASKS_MIN_CONFIG = 1; + private static final String TASK_MAX_DISPLAY = "Tasks max"; public static final String TOPICS_CONFIG = "topics"; @@ -67,7 +71,7 @@ public class ConnectorConfig extends AbstractConfig { config = new ConfigDef() .define(NAME_CONFIG, Type.STRING, Importance.HIGH, NAME_DOC, COMMON_GROUP, 1, Width.MEDIUM, NAME_DISPLAY) .define(CONNECTOR_CLASS_CONFIG, Type.STRING, Importance.HIGH, CONNECTOR_CLASS_DOC, COMMON_GROUP, 2, Width.LONG, CONNECTOR_CLASS_DISPLAY) - .define(TASKS_MAX_CONFIG, Type.INT, TASKS_MAX_DEFAULT, Importance.HIGH, TASKS_MAX_DOC, COMMON_GROUP, 3, Width.SHORT, TASK_MAX_DISPLAY) + .define(TASKS_MAX_CONFIG, Type.INT, TASKS_MAX_DEFAULT, atLeast(TASKS_MIN_CONFIG), Importance.HIGH, TASKS_MAX_DOC, COMMON_GROUP, 3, Width.SHORT, TASK_MAX_DISPLAY) .define(TOPICS_CONFIG, Type.LIST, TOPICS_DEFAULT, Importance.HIGH, TOPICS_DOC, COMMON_GROUP, 4, Width.LONG, TOPICS_DISPLAY); }
