Repository: kafka Updated Branches: refs/heads/trunk 40b1dd3f4 -> 9af2e69ef
KAFKA-4038; Transient failure in DeleteTopicsRequestTest.testErrorDeleteTopicRequests Author: Grant Henke <[email protected]> Reviewers: Ismael Juma <[email protected]> Closes #1737 from granthenke/transient-delete Project: http://git-wip-us.apache.org/repos/asf/kafka/repo Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/9af2e69e Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/9af2e69e Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/9af2e69e Branch: refs/heads/trunk Commit: 9af2e69ef4323dc6c8daf479226f25cc821b1bb6 Parents: 40b1dd3 Author: Grant Henke <[email protected]> Authored: Thu Aug 18 12:31:38 2016 +0100 Committer: Ismael Juma <[email protected]> Committed: Thu Aug 18 12:31:50 2016 +0100 ---------------------------------------------------------------------- .../test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kafka/blob/9af2e69e/core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala ---------------------------------------------------------------------- diff --git a/core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala b/core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala index 4ef1af1..a59316b 100644 --- a/core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala +++ b/core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala @@ -73,7 +73,8 @@ class DeleteTopicsRequestTest extends BaseRequestTest { // Timeout TestUtils.createTopic(zkUtils, timeoutTopic, 5, 2, servers) - validateErrorDeleteTopicRequests(new DeleteTopicsRequest(Set(timeoutTopic).asJava, 1), + // Must be a 0ms timeout to avoid transient test failures. Even a timeout of 1ms has succeeded in the past. + validateErrorDeleteTopicRequests(new DeleteTopicsRequest(Set(timeoutTopic).asJava, 0), Map(timeoutTopic -> Errors.REQUEST_TIMED_OUT)) // The topic should still get deleted eventually TestUtils.waitUntilTrue(() => !servers.head.metadataCache.contains(timeoutTopic), s"Topic $timeoutTopic is never deleted")
