This is an automated email from the ASF dual-hosted git repository. bbejeck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push: new 1898443 HOT_FIX: Change flag so plain RocksDB instance returned (#6297) 1898443 is described below commit 18984434df5295b0940e468ffb467c47b0fd72dd Author: Bill Bejeck <bbej...@gmail.com> AuthorDate: Wed Feb 20 19:09:23 2019 -0500 HOT_FIX: Change flag so plain RocksDB instance returned (#6297) This PR fixes the issue found in the soak testing cluster regarding using RocksDBTimestampedStore when a regular RocksDB store should have been used. Reviewers: Guozhang Wang <wangg...@gmail.com>, Matthias J. Sax <mj...@apache.org>, John Roesler <j...@confluent.io> --- streams/src/main/java/org/apache/kafka/streams/state/Stores.java | 2 +- streams/src/test/java/org/apache/kafka/streams/state/StoresTest.java | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/state/Stores.java b/streams/src/main/java/org/apache/kafka/streams/state/Stores.java index b672f3d..91c895f 100644 --- a/streams/src/main/java/org/apache/kafka/streams/state/Stores.java +++ b/streams/src/main/java/org/apache/kafka/streams/state/Stores.java @@ -84,7 +84,7 @@ public class Stores { */ public static KeyValueBytesStoreSupplier persistentKeyValueStore(final String name) { Objects.requireNonNull(name, "name cannot be null"); - return new RocksDbKeyValueBytesStoreSupplier(name, true); + return new RocksDbKeyValueBytesStoreSupplier(name, false); } /** diff --git a/streams/src/test/java/org/apache/kafka/streams/state/StoresTest.java b/streams/src/test/java/org/apache/kafka/streams/state/StoresTest.java index 1d4a849..9cc1280 100644 --- a/streams/src/test/java/org/apache/kafka/streams/state/StoresTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/state/StoresTest.java @@ -21,11 +21,13 @@ import org.apache.kafka.streams.state.internals.InMemoryKeyValueStore; import org.apache.kafka.streams.state.internals.MemoryNavigableLRUCache; import org.apache.kafka.streams.state.internals.RocksDBSessionStore; import org.apache.kafka.streams.state.internals.RocksDBStore; +import org.apache.kafka.streams.state.internals.RocksDBTimestampedStore; import org.apache.kafka.streams.state.internals.RocksDBWindowStore; import org.junit.Test; import static java.time.Duration.ZERO; import static java.time.Duration.ofMillis; +import static org.hamcrest.CoreMatchers.allOf; import static org.hamcrest.CoreMatchers.nullValue; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.core.IsInstanceOf.instanceOf; @@ -113,7 +115,7 @@ public class StoresTest { @Test public void shouldCreateRocksDbStore() { - assertThat(Stores.persistentKeyValueStore("store").get(), instanceOf(RocksDBStore.class)); + assertThat(Stores.persistentKeyValueStore("store").get(), allOf(not(instanceOf(RocksDBTimestampedStore.class)), instanceOf(RocksDBStore.class))); } @Test