This is an automated email from the ASF dual-hosted git repository. davidarthur pushed a commit to branch 2.4 in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.4 by this push: new 3231d84 Backported changes to fix tests that resolve to multiple addresses. (#9307) 3231d84 is described below commit 3231d84fd42220298f6f1137cea45a76ff569072 Author: Justine Olshan <jols...@confluent.io> AuthorDate: Thu Oct 8 05:37:47 2020 -0700 Backported changes to fix tests that resolve to multiple addresses. (#9307) --- .../src/test/java/org/apache/kafka/clients/ClientUtilsTest.java | 2 +- .../org/apache/kafka/clients/ClusterConnectionStatesTest.java | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java b/clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java index 5dd65ed..572896f 100644 --- a/clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java @@ -107,7 +107,7 @@ public class ClientUtilsTest { @Test public void testResolveDnsLookupAllIps() throws UnknownHostException { - assertEquals(2, ClientUtils.resolve("kafka.apache.org", ClientDnsLookup.USE_ALL_DNS_IPS).size()); + assertTrue(ClientUtils.resolve("kafka.apache.org", ClientDnsLookup.USE_ALL_DNS_IPS).size() > 1); } private List<InetSocketAddress> checkWithoutLookup(String... url) { diff --git a/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java b/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java index 2a427cc..fbb4497 100644 --- a/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java @@ -256,7 +256,7 @@ public class ClusterConnectionStatesTest { @Test public void testMultipleIPsWithDefault() throws UnknownHostException { - assertEquals(2, ClientUtils.resolve(hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS).size()); + assertTrue(ClientUtils.resolve(hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS).size() > 1); connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps, ClientDnsLookup.DEFAULT); InetAddress currAddress = connectionStates.currentAddress(nodeId1); @@ -266,22 +266,21 @@ public class ClusterConnectionStatesTest { @Test public void testMultipleIPsWithUseAll() throws UnknownHostException { - assertEquals(2, ClientUtils.resolve(hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS).size()); + assertTrue(ClientUtils.resolve(hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS).size() > 1); connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS); InetAddress addr1 = connectionStates.currentAddress(nodeId1); connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS); InetAddress addr2 = connectionStates.currentAddress(nodeId1); assertNotSame(addr1, addr2); - connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS); InetAddress addr3 = connectionStates.currentAddress(nodeId1); - assertSame(addr1, addr3); + assertNotSame(addr1, addr3); } @Test public void testHostResolveChange() throws UnknownHostException, ReflectiveOperationException { - assertEquals(2, ClientUtils.resolve(hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS).size()); + assertTrue(ClientUtils.resolve(hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS).size() > 1); connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps, ClientDnsLookup.DEFAULT); InetAddress addr1 = connectionStates.currentAddress(nodeId1);