(kafka) branch trunk updated: KAFKA-17253: Deprecate Leaking Getter Methods in Joined Helper Class (#17164)

[mjsax]

This is an automated email from the ASF dual-hosted git repository.

mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9b53b525e81 KAFKA-17253: Deprecate Leaking Getter Methods in Joined 
Helper Class (#17164)
9b53b525e81 is described below

commit 9b53b525e812c24fc2e25c822479225246b808d7
Author: TengYao Chi <kiting...@gmail.com>
AuthorDate: Fri Sep 13 01:13:22 2024 +0800

    KAFKA-17253: Deprecate Leaking Getter Methods in Joined Helper Class 
(#17164)
    
    Reviewers: Matthias J. Sax <matth...@confluent.io>
---
 .../java/org/apache/kafka/streams/kstream/Joined.java   | 17 +++++++++++++++++
 .../kafka/streams/kstream/internals/JoinedInternal.java |  2 ++
 2 files changed, 19 insertions(+)

diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java 
b/streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java
index 2978f943f31..109879579a6 100644
--- a/streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java
+++ b/streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java
@@ -271,18 +271,35 @@ public class Joined<K, VLeft, VRight> implements 
NamedOperation<Joined<K, VLeft,
         return new Joined<>(keySerde, leftValueSerde, rightValueSerde, name, 
gracePeriod);
     }
 
+
+    /**
+     * @deprecated since 4.0 and should not be used any longer.
+     */
+    @Deprecated
     public Duration gracePeriod() {
         return gracePeriod;
     }
 
+    /**
+     * @deprecated since 4.0 and should not be used any longer.
+     */
+    @Deprecated
     public Serde<K> keySerde() {
         return keySerde;
     }
 
+    /**
+     * @deprecated since 4.0 and should not be used any longer.
+     */
+    @Deprecated
     public Serde<VLeft> valueSerde() {
         return leftValueSerde;
     }
 
+    /**
+     * @deprecated since 4.0 and should not be used any longer.
+     */
+    @Deprecated
     public Serde<VRight> otherValueSerde() {
         return rightValueSerde;
     }
diff --git 
a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/JoinedInternal.java
 
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/JoinedInternal.java
index e01adb5ae4f..b323250e6f1 100644
--- 
a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/JoinedInternal.java
+++ 
b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/JoinedInternal.java
@@ -27,10 +27,12 @@ public class JoinedInternal<K, VLeft, VRight> extends 
Joined<K, VLeft, VRight>
         super(joined);
     }
 
+    @SuppressWarnings("deprecation")
     public Duration gracePeriod() {
         return gracePeriod;
     }
 
+    @SuppressWarnings("deprecation")
     public Serde<K> keySerde() {
         return keySerde;
     }