This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new db25c212edc KAFKA-17883 Fix jvm error caused by UseParNewGC when 
running old kafka client in e2e (#17612)
db25c212edc is described below

commit db25c212edcd20090abb2e754a09eacb181c379f
Author: Yung <[email protected]>
AuthorDate: Mon Oct 28 20:23:32 2024 +0800

    KAFKA-17883 Fix jvm error caused by UseParNewGC when running old kafka 
client in e2e (#17612)
    
    Reviewers: Chia-Ping Tsai <[email protected]>
---
 tests/kafkatest/services/performance/consumer_performance.py | 4 +++-
 tests/kafkatest/services/performance/end_to_end_latency.py   | 4 +++-
 tests/kafkatest/services/performance/producer_performance.py | 3 ++-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/kafkatest/services/performance/consumer_performance.py 
b/tests/kafkatest/services/performance/consumer_performance.py
index 3325fe5298a..34e2e0d05cd 100644
--- a/tests/kafkatest/services/performance/consumer_performance.py
+++ b/tests/kafkatest/services/performance/consumer_performance.py
@@ -16,6 +16,7 @@
 
 import os
 
+from kafkatest.services.kafka.util import fix_opts_for_new_jvm
 from kafkatest.services.performance import PerformanceService
 from kafkatest.services.security.security_config import SecurityConfig
 from kafkatest.version import DEV_BRANCH, V_2_0_0, LATEST_0_10_0
@@ -123,7 +124,8 @@ class ConsumerPerformanceService(PerformanceService):
         return args
 
     def start_cmd(self, node):
-        cmd = "export LOG_DIR=%s;" % ConsumerPerformanceService.LOG_DIR
+        cmd = fix_opts_for_new_jvm(node)
+        cmd += "export LOG_DIR=%s;" % ConsumerPerformanceService.LOG_DIR
         cmd += " export KAFKA_OPTS=%s;" % self.security_config.kafka_opts
         cmd += " export KAFKA_LOG4J_OPTS=\"-Dlog4j.configuration=file:%s\";" % 
ConsumerPerformanceService.LOG4J_CONFIG
         cmd += " %s" % self.path.script("kafka-consumer-perf-test.sh", node)
diff --git a/tests/kafkatest/services/performance/end_to_end_latency.py 
b/tests/kafkatest/services/performance/end_to_end_latency.py
index a35d2e14274..5e66b06104c 100644
--- a/tests/kafkatest/services/performance/end_to_end_latency.py
+++ b/tests/kafkatest/services/performance/end_to_end_latency.py
@@ -15,6 +15,7 @@
 
 import os
 
+from kafkatest.services.kafka.util import fix_opts_for_new_jvm
 from kafkatest.services.performance import PerformanceService
 from kafkatest.services.security.security_config import SecurityConfig
 from kafkatest.version import get_version, V_3_4_0, DEV_BRANCH
@@ -86,7 +87,8 @@ class EndToEndLatencyService(PerformanceService):
                 'zk_connect': self.kafka.zk_connect_setting(),
             })
 
-        cmd = "export KAFKA_LOG4J_OPTS=\"-Dlog4j.configuration=file:%s\"; " % 
EndToEndLatencyService.LOG4J_CONFIG
+        cmd = fix_opts_for_new_jvm(node)
+        cmd += "export KAFKA_LOG4J_OPTS=\"-Dlog4j.configuration=file:%s\"; " % 
EndToEndLatencyService.LOG4J_CONFIG
         if node.version.consumer_supports_bootstrap_server():
             cmd += "KAFKA_OPTS=%(kafka_opts)s %(kafka_run_class)s 
%(java_class_name)s " % args
             cmd += "%(bootstrap_servers)s %(topic)s %(num_records)d %(acks)d 
%(message_bytes)d %(config_file)s" % args
diff --git a/tests/kafkatest/services/performance/producer_performance.py 
b/tests/kafkatest/services/performance/producer_performance.py
index a990d4fe045..e0f00061cb9 100644
--- a/tests/kafkatest/services/performance/producer_performance.py
+++ b/tests/kafkatest/services/performance/producer_performance.py
@@ -19,6 +19,7 @@ from ducktape.utils.util import wait_until
 from ducktape.cluster.remoteaccount import RemoteCommandError
 
 from kafkatest.directory_layout.kafka_path import TOOLS_JAR_NAME, 
TOOLS_DEPENDANT_TEST_LIBS_JAR_NAME
+from kafkatest.services.kafka.util import fix_opts_for_new_jvm
 from kafkatest.services.monitor.http import HttpMetricsCollector
 from kafkatest.services.performance import PerformanceService
 from kafkatest.services.security.security_config import SecurityConfig
@@ -81,7 +82,7 @@ class ProducerPerformanceService(HttpMetricsCollector, 
PerformanceService):
             'metrics_props': ' '.join("%s=%s" % (k, v) for k, v in 
self.http_metrics_client_configs.items())
             })
 
-        cmd = ""
+        cmd = fix_opts_for_new_jvm(node)
 
         if node.version < DEV_BRANCH:
             # In order to ensure more consistent configuration between 
versions, always use the ProducerPerformance

Reply via email to