(kafka) branch 4.0 updated: KAFKA-18553: Update javadoc and comments of ConfigType (#18567)

[mimaison]

This is an automated email from the ASF dual-hosted git repository.

mimaison pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.0 by this push:
     new b14d686b87f KAFKA-18553: Update javadoc and comments of ConfigType 
(#18567)
b14d686b87f is described below

commit b14d686b87f9a771efd1b51f07633b8415bbe662
Author: TengYao Chi <kiting...@gmail.com>
AuthorDate: Mon Jan 20 22:20:36 2025 +0800

    KAFKA-18553: Update javadoc and comments of ConfigType (#18567)
    
    
    Reviewers: Mickael Maison <mickael.mai...@gmail.com>, Chia-Ping Tsai 
<chia7...@gmail.com>, Ismael Juma <ism...@juma.me.uk>, Andrew Schofield 
<aschofi...@confluent.io>, Apoorv Mittal <amit...@confluent.io>
---
 core/src/main/scala/kafka/admin/ConfigCommand.scala                 | 2 +-
 .../src/main/java/org/apache/kafka/server/config/ConfigType.java    | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/core/src/main/scala/kafka/admin/ConfigCommand.scala 
b/core/src/main/scala/kafka/admin/ConfigCommand.scala
index aa38a6c85c4..1cf2a800de9 100644
--- a/core/src/main/scala/kafka/admin/ConfigCommand.scala
+++ b/core/src/main/scala/kafka/admin/ConfigCommand.scala
@@ -63,7 +63,7 @@ object ConfigCommand extends Logging {
 
   private val BrokerDefaultEntityName = ""
   val BrokerLoggerConfigType = "broker-loggers"
-  private val BrokerSupportedConfigTypes = ConfigType.ALL.asScala :+ 
BrokerLoggerConfigType :+ ConfigType.CLIENT_METRICS :+ ConfigType.GROUP
+  private val BrokerSupportedConfigTypes = ConfigType.ALL.asScala :+ 
BrokerLoggerConfigType
   private val DefaultScramIterations = 4096
 
   def main(args: Array[String]): Unit = {
diff --git 
a/server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java 
b/server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java
index 0e76c586fb4..ce280ac2ab6 100644
--- a/server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java
+++ b/server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java
@@ -16,11 +16,10 @@
  */
 package org.apache.kafka.server.config;
 
-import java.util.Arrays;
 import java.util.List;
 
 /**
- * Represents all the entities that can be configured via ZK
+ * Represents all the entities that can be configured.
  */
 public class ConfigType {
     public static final String TOPIC = "topics";
@@ -31,6 +30,5 @@ public class ConfigType {
     public static final String CLIENT_METRICS = "client-metrics";
     public static final String GROUP = "groups";
 
-    // Do not include ClientMetrics and Groups in `all` as they are not 
supported on ZK.
-    public static final List<String> ALL = Arrays.asList(TOPIC, CLIENT, USER, 
BROKER, IP);
+    public static final List<String> ALL = List.of(TOPIC, CLIENT, USER, 
BROKER, IP, CLIENT_METRICS, GROUP);
 }