This is an automated email from the ASF dual-hosted git repository.

divijv pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.0 by this push:
     new 79acb677bf5 KAFKA-18568: Fix flaky test ClientIdQuotaTest (#18612)
79acb677bf5 is described below

commit 79acb677bf5660b42973eda4bcd2ac02826bccd7
Author: Ken Huang <[email protected]>
AuthorDate: Mon Jan 20 23:05:47 2025 +0800

    KAFKA-18568: Fix flaky test ClientIdQuotaTest (#18612)
    
    The reason for flakiness is PR #18080 which modifies the linger.ms config 
from 0 to 5. ClientIdQuotaTest are testing "Low enough quota that a producer 
sending a small payload in a tight loop should get throttled", thus this config 
change Influence this test scenario.
    
    This commits uses the older value of 0ms for linger.ms for 
ClientIdQuotaTest tests.
    
    Reviewers: Ismael Juma <[email protected]>, TaiJuWu <[email protected]>, 
Divij Vaidya <[email protected]>
---
 core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala | 1 +
 1 file changed, 1 insertion(+)

diff --git a/core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala 
b/core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
index 3f5fa5c0457..5657df9a0d5 100644
--- a/core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
+++ b/core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
@@ -61,6 +61,7 @@ abstract class BaseQuotaTest extends IntegrationTestHarness {
   this.producerConfig.setProperty(ProducerConfig.ACKS_CONFIG, "-1")
   this.producerConfig.setProperty(ProducerConfig.BUFFER_MEMORY_CONFIG, 
"300000")
   this.producerConfig.setProperty(ProducerConfig.CLIENT_ID_CONFIG, 
producerClientId)
+  this.producerConfig.setProperty(ProducerConfig.LINGER_MS_CONFIG, 0.toString)
   this.consumerConfig.setProperty(ConsumerConfig.GROUP_ID_CONFIG, "QuotasTest")
   
this.consumerConfig.setProperty(ConsumerConfig.MAX_PARTITION_FETCH_BYTES_CONFIG,
 4096.toString)
   this.consumerConfig.setProperty(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, 
"earliest")

Reply via email to