This is an automated email from the ASF dual-hosted git repository.
davidarthur pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 0ebc3e83c5a MINOR Mar 12 Flaky tests (#19190)
0ebc3e83c5a is described below
commit 0ebc3e83c5ace577ce5632724d4f998302e31086
Author: David Arthur <[email protected]>
AuthorDate: Wed Mar 12 13:47:35 2025 -0400
MINOR Mar 12 Flaky tests (#19190)
Mark the following tests as flaky:
* StickyAssignorTest > testLargeAssignmentAndGroupWithUniformSubscription
* DeleteSegmentsByRetentionTimeTest
* QuorumControllerTest > testUncleanShutdownBrokerElrEnabled
Reviewers: Andrew Schofield <[email protected]>
---
build.gradle | 2 ++
.../apache/kafka/clients/consumer/StickyAssignorTest.java | 12 ++++++++++++
.../org/apache/kafka/controller/QuorumControllerTest.java | 2 ++
.../integration/DeleteSegmentsByRetentionTimeTest.java | 2 ++
4 files changed, 18 insertions(+)
diff --git a/build.gradle b/build.gradle
index 2afc78fa8c8..2085130bc1b 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1301,6 +1301,7 @@ project(':metadata') {
testImplementation project(':clients').sourceSets.test.output
testImplementation project(':raft').sourceSets.test.output
testImplementation project(':server-common').sourceSets.test.output
+ testImplementation project(':test-common:test-common-util')
testRuntimeOnly runtimeTestLibs
@@ -2234,6 +2235,7 @@ project(':storage') {
testImplementation project(':core').sourceSets.test.output
testImplementation project(':test-common:test-common-internal-api')
testImplementation project(':test-common:test-common-runtime')
+ testImplementation project(':test-common:test-common-util')
testImplementation project(':server')
testImplementation project(':server-common')
testImplementation project(':server-common').sourceSets.test.output
diff --git
a/clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java
b/clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java
index 65ea13100eb..74180a4edcf 100644
---
a/clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java
+++
b/clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java
@@ -24,13 +24,16 @@ import
org.apache.kafka.clients.consumer.internals.AbstractStickyAssignorTest;
import org.apache.kafka.common.PartitionInfo;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.protocol.types.Struct;
+import org.apache.kafka.common.test.api.Flaky;
import org.apache.kafka.common.utils.CollectionUtils;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.EnumSource;
import org.junit.jupiter.params.provider.MethodSource;
+import org.junit.jupiter.params.provider.ValueSource;
import java.nio.ByteBuffer;
import java.util.ArrayList;
@@ -45,6 +48,7 @@ import java.util.Optional;
import static java.util.Collections.emptyList;
import static
org.apache.kafka.clients.consumer.StickyAssignor.serializeTopicPartitionAssignment;
+import static
org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignorTest.TEST_NAME_WITH_CONSUMER_RACK;
import static
org.apache.kafka.clients.consumer.internals.AbstractPartitionAssignorTest.TEST_NAME_WITH_RACK_CONFIG;
import static
org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor.DEFAULT_GENERATION;
import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -81,6 +85,14 @@ public class StickyAssignorTest extends
AbstractStickyAssignorTest {
return serializeTopicPartitionAssignment(new MemberData(partitions,
Optional.of(generation)));
}
+ @Timeout(30)
+ @ParameterizedTest(name = TEST_NAME_WITH_CONSUMER_RACK)
+ @ValueSource(booleans = {false, true})
+ @Flaky(value = "KAFKA-18797", comment = "Remove this override once the
flakiness has been resolved.")
+ public void testLargeAssignmentAndGroupWithUniformSubscription(boolean
hasConsumerRack) {
+
super.testLargeAssignmentAndGroupWithUniformSubscription(hasConsumerRack);
+ }
+
@ParameterizedTest(name = TEST_NAME_WITH_RACK_CONFIG)
@EnumSource(RackConfig.class)
public void
testAllConsumersHaveOwnedPartitionInvalidatedWhenClaimedByMultipleConsumersInSameGenerationWithEqualPartitionsPerConsumer(RackConfig
rackConfig) {
diff --git
a/metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
b/metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
index f50ba5a9110..220627ed834 100644
---
a/metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
+++
b/metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
@@ -66,6 +66,7 @@ import org.apache.kafka.common.requests.AlterPartitionRequest;
import org.apache.kafka.common.requests.ApiError;
import org.apache.kafka.common.security.auth.KafkaPrincipal;
import org.apache.kafka.common.security.auth.SecurityProtocol;
+import org.apache.kafka.common.test.api.Flaky;
import org.apache.kafka.common.utils.LogContext;
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.common.utils.Utils;
@@ -378,6 +379,7 @@ public class QuorumControllerTest {
}
}
+ @Flaky("KAFKA-18845")
@Test
public void testUncleanShutdownBrokerElrEnabled() throws Throwable {
List<Integer> allBrokers = Arrays.asList(1, 2, 3);
diff --git
a/storage/src/test/java/org/apache/kafka/tiered/storage/integration/DeleteSegmentsByRetentionTimeTest.java
b/storage/src/test/java/org/apache/kafka/tiered/storage/integration/DeleteSegmentsByRetentionTimeTest.java
index 2c196713d12..09b1475014c 100644
---
a/storage/src/test/java/org/apache/kafka/tiered/storage/integration/DeleteSegmentsByRetentionTimeTest.java
+++
b/storage/src/test/java/org/apache/kafka/tiered/storage/integration/DeleteSegmentsByRetentionTimeTest.java
@@ -17,10 +17,12 @@
package org.apache.kafka.tiered.storage.integration;
import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.api.Flaky;
import java.util.Collections;
import java.util.Map;
+@Flaky("KAFKA-18606")
public final class DeleteSegmentsByRetentionTimeTest extends
BaseDeleteSegmentsTest {
@Override
