(kafka) branch 4.0 updated: MINOR: small optimization by judgment (#19386)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.0 by this push:
     new 8de7b69ced9 MINOR: small optimization by judgment (#19386)
8de7b69ced9 is described below

commit 8de7b69ced939fdf35f8867c3aeba2d6dac67dd7
Author: Xuan-Zhang Gong <gongxuanzhangm...@gmail.com>
AuthorDate: Sun Apr 6 22:08:05 2025 +0800

    MINOR: small optimization by judgment (#19386)
    
    judgments can help avoid unnecessary `segments.sizeInBytes()`  loops
    
    from https://github.com/apache/kafka/pull/18393/files#r2029925512
    
    Reviewers: PoAn Yang <pay...@apache.org>, Chia-Ping Tsai
    <chia7...@gmail.com>
---
 .../main/java/org/apache/kafka/storage/internals/log/LocalLog.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java 
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java
index 817da5c8318..c939fffdc52 100644
--- a/storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java
+++ b/storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java
@@ -470,9 +470,10 @@ public class LocalLog {
         return maybeHandleIOException(
                 () -> "Exception while reading from " + topicPartition + " in 
dir " + dir.getParent(),
                 () -> {
-                    logger.trace("Reading maximum {} bytes at offset {} from 
log with total length {} bytes",
-                            maxLength, startOffset, segments.sizeInBytes());
-
+                    if (logger.isTraceEnabled()) {
+                        logger.trace("Reading maximum {} bytes at offset {} 
from log with total length {} bytes",
+                                maxLength, startOffset, 
segments.sizeInBytes());
+                    }
                     LogOffsetMetadata endOffsetMetadata = nextOffsetMetadata;
                     long endOffset = endOffsetMetadata.messageOffset;
                     Optional<LogSegment> segmentOpt = 
segments.floorSegment(startOffset);