This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new a4ea5dff0d0 KAFKA-19099 Remove GroupSyncKey, GroupJoinKey, and
MemberKey (#19413)
a4ea5dff0d0 is described below
commit a4ea5dff0d06005f7fd61076eb30dfe67c0a54f9
Author: Nick Guo <[email protected]>
AuthorDate: Wed Apr 9 01:51:32 2025 +0800
KAFKA-19099 Remove GroupSyncKey, GroupJoinKey, and MemberKey (#19413)
They are useless after removing old coordinator.
Reviewers: David Jacot <[email protected]>, Chia-Ping Tsai
<[email protected]>
---
.../kafka/server/purgatory/GroupJoinKey.java | 49 ---------------------
.../kafka/server/purgatory/GroupSyncKey.java | 49 ---------------------
.../apache/kafka/server/purgatory/MemberKey.java | 51 ----------------------
3 files changed, 149 deletions(-)
diff --git
a/server-common/src/main/java/org/apache/kafka/server/purgatory/GroupJoinKey.java
b/server-common/src/main/java/org/apache/kafka/server/purgatory/GroupJoinKey.java
deleted file mode 100644
index 7789df42fe6..00000000000
---
a/server-common/src/main/java/org/apache/kafka/server/purgatory/GroupJoinKey.java
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.kafka.server.purgatory;
-
-import java.util.Objects;
-
-/**
- * Used by delayed-join operations
- */
-public class GroupJoinKey implements DelayedOperationKey {
-
- private final String groupId;
-
- public GroupJoinKey(String groupId) {
- this.groupId = groupId;
- }
-
- @Override
- public String keyLabel() {
- return "join-" + groupId;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) return true;
- if (o == null || getClass() != o.getClass()) return false;
- GroupJoinKey that = (GroupJoinKey) o;
- return Objects.equals(groupId, that.groupId);
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(groupId);
- }
-}
diff --git
a/server-common/src/main/java/org/apache/kafka/server/purgatory/GroupSyncKey.java
b/server-common/src/main/java/org/apache/kafka/server/purgatory/GroupSyncKey.java
deleted file mode 100644
index 3dfffc489b6..00000000000
---
a/server-common/src/main/java/org/apache/kafka/server/purgatory/GroupSyncKey.java
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.kafka.server.purgatory;
-
-import java.util.Objects;
-
-/**
- * Used by delayed-sync operations
- */
-public class GroupSyncKey implements DelayedOperationKey {
-
- private final String groupId;
-
- public GroupSyncKey(String groupId) {
- this.groupId = groupId;
- }
-
- @Override
- public String keyLabel() {
- return "sync-" + groupId;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) return true;
- if (o == null || getClass() != o.getClass()) return false;
- GroupSyncKey that = (GroupSyncKey) o;
- return Objects.equals(groupId, that.groupId);
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(groupId);
- }
-}
diff --git
a/server-common/src/main/java/org/apache/kafka/server/purgatory/MemberKey.java
b/server-common/src/main/java/org/apache/kafka/server/purgatory/MemberKey.java
deleted file mode 100644
index 425493bc182..00000000000
---
a/server-common/src/main/java/org/apache/kafka/server/purgatory/MemberKey.java
+++ /dev/null
@@ -1,51 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.kafka.server.purgatory;
-
-import java.util.Objects;
-
-/**
- * Used by delayed-join-group operations
- */
-public class MemberKey implements DelayedOperationKey {
-
- private final String groupId;
- private final String consumerId;
-
- public MemberKey(String groupId, String consumerId) {
- this.groupId = groupId;
- this.consumerId = consumerId;
- }
-
- @Override
- public String keyLabel() {
- return groupId + "-" + consumerId;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) return true;
- if (o == null || getClass() != o.getClass()) return false;
- MemberKey memberKey = (MemberKey) o;
- return Objects.equals(groupId, memberKey.groupId) &&
Objects.equals(consumerId, memberKey.consumerId);
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(groupId, consumerId);
- }
-}
