This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 54fd1361e59 KAFKA-19264 Remove fallback for thread pool sizes in
RemoteLogManagerConfig (#19673)
54fd1361e59 is described below
commit 54fd1361e59b0a3cc2be3b693fc0e86b71706676
Author: Kuan-Po Tseng <[email protected]>
AuthorDate: Sun May 11 23:48:45 2025 +0800
KAFKA-19264 Remove fallback for thread pool sizes in RemoteLogManagerConfig
(#19673)
The fallback mechanism for `remote.log.manager.copier.thread.pool.size`
and `remote.log.manager.expiration.thread.pool.size` defaulting to
`remote.log.manager.thread.pool.size` was introduced in KIP-950. This
approach was abandoned in KIP-1030, where default values were changed
from -1 to 10, and a configuration validator enforcing a minimum value
of 1 was added. As a result, this commit removes the fallback mechanism
from `RemoteLogManagerConfig.java` to align with the new defaults and
validation.
Reviewers: Chia-Ping Tsai <[email protected]>
---
.../kafka/server/log/remote/storage/RemoteLogManagerConfig.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
a/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
b/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
index 8dc4449817c..0f58ef4e26b 100644
---
a/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
+++
b/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
@@ -396,13 +396,11 @@ public final class RemoteLogManagerConfig {
}
public int remoteLogManagerCopierThreadPoolSize() {
- int size =
config.getInt(REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP);
- return size == -1 ? remoteLogManagerThreadPoolSize() : size;
+ return config.getInt(REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP);
}
public int remoteLogManagerExpirationThreadPoolSize() {
- int size =
config.getInt(REMOTE_LOG_MANAGER_EXPIRATION_THREAD_POOL_SIZE_PROP);
- return size == -1 ? remoteLogManagerThreadPoolSize() : size;
+ return
config.getInt(REMOTE_LOG_MANAGER_EXPIRATION_THREAD_POOL_SIZE_PROP);
}
public long remoteLogManagerTaskIntervalMs() {