(kafka) branch trunk updated: KAFKA-19267 the min version used by ListOffsetsRequest should be 1 rather than 0 (#19709)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new f55565d3213 KAFKA-19267 the min version used by ListOffsetsRequest 
should be 1 rather than 0 (#19709)
f55565d3213 is described below

commit f55565d321303b297b51b15acd9c120107d4b8b7
Author: Yunchi Pang <yunchip...@gmail.com>
AuthorDate: Thu May 15 19:33:16 2025 -0700

    KAFKA-19267 the min version used by ListOffsetsRequest should be 1 rather 
than 0 (#19709)
    
    Updates the min version used by `ListOffsetsRequest` to
    `ApiKeys.LIST_OFFSETS.oldestVersion()` rather than hardcoding `1`.
    
    Reviewers: Ken Huang <s7133...@gmail.com>, PoAn Yang
     <pay...@apache.org>, TengYao Chi <frankvi...@apache.org>, Chia-Ping
     Tsai <chia7...@gmail.com>
---
 .../java/org/apache/kafka/common/requests/ListOffsetsRequest.java     | 4 ++--
 .../java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java
 
b/clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java
index 065a0b5d8a8..7415412d050 100644
--- 
a/clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java
+++ 
b/clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java
@@ -66,7 +66,7 @@ public class ListOffsetsRequest extends AbstractRequest {
                                           boolean requireMaxTimestamp,
                                           boolean 
requireEarliestLocalTimestamp,
                                           boolean 
requireTieredStorageTimestamp) {
-            short minVersion = 0;
+            short minVersion = ApiKeys.LIST_OFFSETS.oldestVersion();
             if (requireTieredStorageTimestamp)
                 minVersion = 9;
             else if (requireEarliestLocalTimestamp)
@@ -81,7 +81,7 @@ public class ListOffsetsRequest extends AbstractRequest {
         }
 
         public static Builder forReplica(short allowedVersion, int replicaId) {
-            return new Builder((short) 0, allowedVersion, replicaId, 
IsolationLevel.READ_UNCOMMITTED);
+            return new Builder(ApiKeys.LIST_OFFSETS.oldestVersion(), 
allowedVersion, replicaId, IsolationLevel.READ_UNCOMMITTED);
         }
 
         private Builder(short oldestAllowedVersion,
diff --git 
a/clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java
 
b/clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java
index 2aa2f0c150b..2cf4cbc00c9 100644
--- 
a/clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java
+++ 
b/clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java
@@ -135,7 +135,7 @@ public class ListOffsetsRequestTest {
         ListOffsetsRequest.Builder requireTieredStorageTimestampRequestBuilder 
= ListOffsetsRequest.Builder
             .forConsumer(false, IsolationLevel.READ_UNCOMMITTED, false, false, 
true);
 
-        assertEquals((short) 0, consumerRequestBuilder.oldestAllowedVersion());
+        assertEquals((short) 1, consumerRequestBuilder.oldestAllowedVersion());
         assertEquals((short) 1, 
requireTimestampRequestBuilder.oldestAllowedVersion());
         assertEquals((short) 2, 
requestCommittedRequestBuilder.oldestAllowedVersion());
         assertEquals((short) 7, 
maxTimestampRequestBuilder.oldestAllowedVersion());