This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1407b12e2f4 KAFKA-19313 Replace 
LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by UnifiedLog.UNKNOWN_OFFSET 
(#19767)
1407b12e2f4 is described below

commit 1407b12e2f491d62c359968aa5e173032eea67ef
Author: Yu-Syuan Jheng <[email protected]>
AuthorDate: Sat May 24 11:33:26 2025 -0400

    KAFKA-19313 Replace LogOffsetMetadata#UNIFIED_LOG_UNKNOWN_OFFSET by 
UnifiedLog.UNKNOWN_OFFSET (#19767)
    
    Replaces the UNIFIED_LOG_UNKNOWN_OFFSET constant in LogOffsetMetadata
    with UnifiedLog.UNKNOWN_OFFSET.
    
    Reviewers: PoAn Yang <[email protected]>, Ken Huang
    <[email protected]>, YuChia Ma <[email protected]>, Chia-Ping
    Tsai <[email protected]>
---
 .../org/apache/kafka/storage/internals/log/LogOffsetMetadata.java | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git 
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java
 
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java
index 71f5f67c972..fa13b231e46 100644
--- 
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java
+++ 
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java
@@ -26,18 +26,16 @@ import org.apache.kafka.common.KafkaException;
  */
 public final class LogOffsetMetadata {
 
-    //TODO KAFKA-14484 remove once UnifiedLog has been moved to the storage 
module
-    private static final long UNIFIED_LOG_UNKNOWN_OFFSET = -1L;
     private static final int UNKNOWN_FILE_POSITION = -1;
 
-    public static final LogOffsetMetadata UNKNOWN_OFFSET_METADATA = new 
LogOffsetMetadata(-1L, UNIFIED_LOG_UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION);
+    public static final LogOffsetMetadata UNKNOWN_OFFSET_METADATA = new 
LogOffsetMetadata(-1L, UnifiedLog.UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION);
 
     public final long messageOffset;
     public final long segmentBaseOffset;
     public final int relativePositionInSegment;
 
     public LogOffsetMetadata(long messageOffset) {
-        this(messageOffset, UNIFIED_LOG_UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION);
+        this(messageOffset, UnifiedLog.UNKNOWN_OFFSET, UNKNOWN_FILE_POSITION);
     }
 
     public LogOffsetMetadata(long messageOffset,
@@ -75,7 +73,7 @@ public final class LogOffsetMetadata {
 
     // decide if the offset metadata only contains message offset info
     public boolean messageOffsetOnly() {
-        return segmentBaseOffset == UNIFIED_LOG_UNKNOWN_OFFSET && 
relativePositionInSegment == UNKNOWN_FILE_POSITION;
+        return segmentBaseOffset == UnifiedLog.UNKNOWN_OFFSET && 
relativePositionInSegment == UNKNOWN_FILE_POSITION;
     }
 
     @Override

Reply via email to