(kafka) branch trunk updated: KAFKA-19499: Corrected the logger name in PersisterStateManagerHandler (#20175)

[mittal]

This is an automated email from the ASF dual-hosted git repository.

mittal pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1ae41736017 KAFKA-19499: Corrected the logger name in 
PersisterStateManagerHandler (#20175)
1ae41736017 is described below

commit 1ae41736017eaf06bc869249f6c52a23d7c5551e
Author: Chirag Wadhwa <cwad...@confluent.io>
AuthorDate: Thu Jul 24 16:58:58 2025 +0530

    KAFKA-19499: Corrected the logger name in PersisterStateManagerHandler 
(#20175)
    
    This PR corrects the name of logger in the inner class
    PersisterStateManagerHandler. After this change it will be possible to
    change the log level dynamically in the kafka brokers. This PR also
    includes a small change in a log line in GroupCoordinatorService, making
    it clearer.
    
    Reviewers: Apoorv Mittal <apoorvmitta...@gmail.com>, Sushant Mahajan
    <smaha...@confluent.io>, Lan Ding <isdin...@163.com>, TengYao Chi
    <frankvi...@apache.org>
---
 .../apache/kafka/coordinator/group/GroupCoordinatorService.java    | 2 +-
 .../apache/kafka/server/share/persister/PersisterStateManager.java | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
index 662b91126e0..be2636b2bad 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
@@ -796,7 +796,7 @@ public class GroupCoordinatorService implements 
GroupCoordinator {
             }
             return performShareGroupStateMetadataInitialize(groupId, 
topicPartitionMap, defaultResponse);
         }
-        log.error("Received error while calling initialize state for {} on 
persister {}.", groupId, persisterError.code());
+        log.error("Received error while calling initialize state for {} on 
persister, errorCode: {}.", groupId, persisterError.code());
         return uninitializeShareGroupState(persisterError, groupId, 
topicPartitionMap);
     }
 
diff --git 
a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
 
b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
index ccfae329c7b..4569455aee1 100644
--- 
a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
+++ 
b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
@@ -221,7 +221,7 @@ public class PersisterStateManager {
     public abstract class PersisterStateManagerHandler implements 
RequestCompletionHandler {
         protected Node coordinatorNode;
         private final BackoffManager findCoordBackoff;
-        protected final Logger log = LoggerFactory.getLogger(getClass());
+        protected final Logger log;
         private Consumer<ClientResponse> onCompleteCallback;
         protected final SharePartitionKey partitionKey;
 
@@ -237,6 +237,11 @@ public class PersisterStateManager {
             this.onCompleteCallback = response -> {
             }; // noop
             partitionKey = SharePartitionKey.getInstance(groupId, topicId, 
partition);
+            String canonicalName = getClass().getCanonicalName();
+            if (canonicalName == null) {
+                canonicalName = getClass().getName();
+            }
+            log = LoggerFactory.getLogger(canonicalName);
         }
 
         /**