This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 8065d5cb1d1 MINOR: Making sure log appender is closed in
ShareConsumerImplTest.java::testFailConstructor (#20514)
8065d5cb1d1 is described below
commit 8065d5cb1d13e183403be9df7f8a072e44d9f49e
Author: Genseric Ghiro <[email protected]>
AuthorDate: Tue Sep 9 19:03:19 2025 -0400
MINOR: Making sure log appender is closed in
ShareConsumerImplTest.java::testFailConstructor (#20514)
Similarly to what was done for
AsyncKafkaConsumerTest::testFailConstructor,
[here](https://github.com/apache/kafka/pull/20491)
Reviewers: Lianet Magrans <[email protected]>, Chia-Ping Tsai
<[email protected]>
---
.../clients/consumer/internals/ShareConsumerImplTest.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git
a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java
b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java
index 0fa3def7c15..5dddd0772df 100644
---
a/clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java
+++
b/clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java
@@ -213,18 +213,19 @@ public class ShareConsumerImplTest {
props.put(ConsumerConfig.METRIC_REPORTER_CLASSES_CONFIG,
"an.invalid.class");
final ConsumerConfig config = new ConsumerConfig(props);
- LogCaptureAppender appender = LogCaptureAppender.createAndRegister();
- KafkaException ce = assertThrows(
+ try (LogCaptureAppender appender =
LogCaptureAppender.createAndRegister()) {
+ KafkaException ce = assertThrows(
KafkaException.class,
() -> newConsumer(config));
- assertTrue(ce.getMessage().contains("Failed to construct Kafka share
consumer"), "Unexpected exception message: " + ce.getMessage());
- assertTrue(ce.getCause().getMessage().contains("Class an.invalid.class
cannot be found"), "Unexpected cause: " + ce.getCause());
+ assertTrue(ce.getMessage().contains("Failed to construct Kafka
share consumer"), "Unexpected exception message: " + ce.getMessage());
+ assertTrue(ce.getCause().getMessage().contains("Class
an.invalid.class cannot be found"), "Unexpected cause: " + ce.getCause());
- boolean npeLogged = appender.getEvents().stream()
+ boolean npeLogged = appender.getEvents().stream()
.flatMap(event -> event.getThrowableInfo().stream())
.anyMatch(str -> str.contains("NullPointerException"));
- assertFalse(npeLogged, "Unexpected NullPointerException during
consumer construction");
+ assertFalse(npeLogged, "Unexpected NullPointerException during
consumer construction");
+ }
}
@Test
