jbonofre commented on code in PR #1785: URL: https://github.com/apache/karaf/pull/1785#discussion_r1367146223
########## examples/karaf-websocket-example/src/main/java/org/apache/karaf/examples/websocket/WebsocketExampleServlet.java: ########## @@ -16,16 +16,16 @@ */ package org.apache.karaf.examples.websocket; -import org.eclipse.jetty.websocket.servlet.WebSocketServlet; -import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory; +import org.eclipse.jetty.websocket.server.JettyWebSocketServlet; +import org.eclipse.jetty.websocket.server.JettyWebSocketServletFactory; import javax.servlet.annotation.WebServlet; @WebServlet(name = "Example WebSocket Servlet", urlPatterns = { "/example-websocket "}) -public class WebsocketExampleServlet extends WebSocketServlet { +public class WebsocketExampleServlet extends JettyWebSocketServlet { Review Comment: We should use the websocket handling here, not the Jetty one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org