jbonofre commented on code in PR #1946:
URL: https://github.com/apache/karaf/pull/1946#discussion_r2079990083
##########
shell/ssh/src/main/java/org/apache/karaf/shell/ssh/ShellCommand.java:
##########
@@ -62,7 +62,7 @@ public class ShellCommand implements Command {
private OutputStream out;
private OutputStream err;
private ExitCallback callback;
- private ServerSession session;
+ private ServerSession serverSession;
Review Comment:
Why changing the name here ? It's causing noise for nothing (this class is
not actually chaanged in the PR).
##########
shell/ssh/src/main/java/org/apache/karaf/shell/ssh/ShellFactoryImpl.java:
##########
@@ -108,6 +108,7 @@ public void start(ChannelSession channelSession,
Environment environment) throws
for (Map.Entry<String, String> e :
environment.getEnv().entrySet()) {
shell.put(e.getKey(), e.getValue());
}
+ shell.put(Subject.class.getName(), subject);
Review Comment:
Is it not potentially a security "issue" ? I'm fine adding the `Subject` in
the session, but wonder if it's very useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
