CptBartender commented on code in PR #2911:
URL: https://github.com/apache/karaf/pull/2911#discussion_r4173285127
##########
util/src/main/java/org/apache/karaf/util/tracker/BaseActivator.java:
##########
@@ -35,29 +37,37 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.regex.Pattern;
import java.util.stream.Stream;
import java.util.stream.StreamSupport;
-
-import org.osgi.framework.*;
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.Constants;
+import org.osgi.framework.InvalidSyntaxException;
+import org.osgi.framework.ServiceReference;
+import org.osgi.framework.ServiceRegistration;
import org.osgi.service.cm.Configuration;
import org.osgi.service.cm.ConfigurationAdmin;
+import org.osgi.service.cm.ManagedService;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class BaseActivator implements BundleActivator, Runnable, ThreadFactory
{
+public class BaseActivator implements BundleActivator, ManagedService,
Runnable, ThreadFactory {
Review Comment:
It seems weird to me that the `BaseActivator` _is_ a `ManagedService` but
doesn't implement that interface, but I see your point - reversed.
##########
util/src/main/java/org/apache/karaf/util/tracker/BaseActivator.java:
##########
@@ -35,29 +37,37 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.regex.Pattern;
import java.util.stream.Stream;
import java.util.stream.StreamSupport;
-
-import org.osgi.framework.*;
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.Constants;
+import org.osgi.framework.InvalidSyntaxException;
+import org.osgi.framework.ServiceReference;
+import org.osgi.framework.ServiceRegistration;
import org.osgi.service.cm.Configuration;
import org.osgi.service.cm.ConfigurationAdmin;
+import org.osgi.service.cm.ManagedService;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class BaseActivator implements BundleActivator, Runnable, ThreadFactory
{
+public class BaseActivator implements BundleActivator, ManagedService,
Runnable, ThreadFactory {
Review Comment:
It seems weird to me that the `BaseActivator` _is_ a `ManagedService` but
doesn't implement that interface, but I see your point - reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
