jbonofre opened a new pull request, #3068:
URL: https://github.com/apache/karaf/pull/3068

   Backport of #3067 to karaf-4.4.x.
   
   ## Problem
   
   `LogTest` fails now and then on the ubuntu CI job with 
`IllegalStateException: Unrecognized configuration` on `log:set`, and once it 
happens every remaining test of the class fails, retries included. It hit #3060 
most recently.
   
   ## Root cause
   
   A race in Felix fileinstall 3.7.4, which 4.4.x uses as well: every `log:set` 
makes fileinstall rewrite `etc/org.ops4j.pax.logging.cfg` in place, and a 
scanner poll landing while the file is truncated loads it empty into 
ConfigAdmin. The write-back of that empty configuration then removes every key 
from the file, so the configuration never recovers. See #3067 for the details.
   
   ## Fix
   
   Disable fileinstall's config write-back 
(`felix.fileinstall.enableConfigSave=false`) in the `LogTest` container. 
`LogTest` checks the log commands against ConfigAdmin, not against the file.
   
   The cherry-pick applied cleanly: `LogTest` is identical on main and 4.4.x.
   
   ## Testing
   
   `mvn -pl itests/test test -Dtest=LogTest` passes locally on this branch (JDK 
17, macOS). As the race is rare and mostly hit on Linux, the actual 
confirmation is CI over time.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to