ponziani commented on PR #2979: URL: https://github.com/apache/karaf/pull/2979#issuecomment-6624576114
Rebased on `main` after #2928. The only conflict was the offline flag in `Builder#createMavenResolver()`. It now uses the factory PID with the missing dot fixed (`pid + ".offline"`). The split-local-repository handling stays in `MojoSupport` and builds the Pax URL `localRepository` option string. That's still correct, because the plugin uses the Pax URL resolver provider. If you'd rather move it into `maven/resolver-paxurl` or behind the SPI, I'm happy to do that in a follow-up. `MojoSupportTest` and the `profile` tests pass locally. @jbonofre @CptBartender, could you take another look? It would be nice if this makes into the 4.5 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
