This is an automated email from the ASF dual-hosted git repository.
jbonofre pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/karaf.git
The following commit(s) were added to refs/heads/main by this push:
new 94a68e3c8d Fail tests when the expected exception is missing (#3054)
94a68e3c8d is described below
commit 94a68e3c8d47f08609ddc9c7caebae15da13901e
Author: Sharang Gupta <[email protected]>
AuthorDate: Thu Nov 12 05:07:11 2026 +0000
Fail tests when the expected exception is missing (#3054)
Six tests expected an exception in a try/catch but had no fail() after
the call, so they passed when nothing was thrown. Add the fail() their
sibling tests already use.
---
.../core/src/test/java/org/apache/karaf/features/RepositoryTest.java | 1 +
instance/src/test/java/org/apache/karaf/instance/main/ExecuteTest.java | 3 +++
.../karaf/jaas/modules/properties/PropertiesLoginModuleTest.java | 1 +
.../src/test/java/org/apache/karaf/tooling/RunMojoTest.java | 1 +
4 files changed, 6 insertions(+)
diff --git
a/features/core/src/test/java/org/apache/karaf/features/RepositoryTest.java
b/features/core/src/test/java/org/apache/karaf/features/RepositoryTest.java
index 0ddee486ce..ce65e7f024 100644
--- a/features/core/src/test/java/org/apache/karaf/features/RepositoryTest.java
+++ b/features/core/src/test/java/org/apache/karaf/features/RepositoryTest.java
@@ -194,6 +194,7 @@ public class RepositoryTest extends TestCase {
String uri =
"src/test/resources/org/apache/karaf/shell/features/repo1.xml";
try {
new RepositoryImpl(new URI(uri));
+ fail("Expected RepositoryImpl to fail for URI " + uri);
} catch (Exception e) {
assertTrue(e.getMessage().contains(uri));
}
diff --git
a/instance/src/test/java/org/apache/karaf/instance/main/ExecuteTest.java
b/instance/src/test/java/org/apache/karaf/instance/main/ExecuteTest.java
index 1e49a88e38..269c0e9ac8 100644
--- a/instance/src/test/java/org/apache/karaf/instance/main/ExecuteTest.java
+++ b/instance/src/test/java/org/apache/karaf/instance/main/ExecuteTest.java
@@ -50,6 +50,7 @@ public class ExecuteTest extends TestCase {
try {
Execute.main(new String [] {});
+ fail("Expected Execute.main to exit with 0");
} catch (RuntimeException re) {
assertEquals("0", re.getMessage());
@@ -65,6 +66,7 @@ public class ExecuteTest extends TestCase {
public void testNonexistingCommand() throws Exception {
try {
Execute.main(new String [] {"bheuaark"});
+ fail("Expected Execute.main to exit with -1");
} catch (RuntimeException re) {
assertEquals("-1", re.getMessage());
}
@@ -79,6 +81,7 @@ public class ExecuteTest extends TestCase {
try {
Execute.main(new String [] {"create"});
+ fail("Expected Execute.main to exit with -2");
} catch (RuntimeException re) {
assertEquals("-2", re.getMessage());
diff --git
a/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java
b/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java
index f1ae778d9f..613df02e80 100644
---
a/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java
+++
b/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/properties/PropertiesLoginModuleTest.java
@@ -185,6 +185,7 @@ public class PropertiesLoginModuleTest {
public void testNonExistantPropertiesFile() throws LoginException,
IOException, UnsupportedCallbackException {
try {
testWithUsersFile(File.separator + "test" + File.separator +
"users.properties");
+ Assert.fail("LoginException expected");
} catch (LoginException e) {
Assert.assertEquals("Users file not found at " + File.separator +
"test" + File.separator + "users.properties", e.getMessage());
}
diff --git
a/tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/RunMojoTest.java
b/tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/RunMojoTest.java
index 5e27ad2ebe..011350816c 100644
---
a/tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/RunMojoTest.java
+++
b/tooling/karaf-maven-plugin/src/test/java/org/apache/karaf/tooling/RunMojoTest.java
@@ -439,6 +439,7 @@ public class RunMojoTest extends EasyMockSupport {
try {
mojo.addFeatures(null);
+ fail("Expected MojoExecutionException to be thrown");
} catch (MojoExecutionException e) {
assertEquals("Failed to add features to karaf", e.getMessage());
}