baldimir commented on code in PR #1104:
URL:
https://github.com/apache/incubator-kie-kogito-pipelines/pull/1104#discussion_r1347269700
##########
.ci/actions/maven/action.yml:
##########
@@ -48,70 +65,11 @@ runs:
key: ${{ inputs.cache-key-prefix }}-m2-${{ hashFiles('**/pom.xml') }}
restore-keys: ${{ inputs.cache-key-prefix }}-m2
- name: Setup Maven Settings
- uses: whelk-io/maven-settings-xml-action@v21
- with:
- repositories: >
- [
- {
- "id": "jboss-public-repository-group",
- "name": "JBoss Public Repository Group",
- "url":
"https://repository.jboss.org/nexus/content/groups/public";,
- "releases": {
- "enabled": "true",
- "updatePolicy": "never"
- },
- "snapshots": {
- "enabled": "${{ inputs.allow-snapshots }}",
- "updatePolicy": "never"
- }
- },
- {
- "id": "kogito-staging-repository-group",
- "name": "Kogito Staging Repositories",
- "url":
"https://repository.jboss.org/nexus/content/groups/kogito-public";,
- "releases": {
- "enabled": "true",
- "updatePolicy": "never"
- },
- "snapshots": {
- "enabled": "${{ inputs.allow-snapshots }}",
- "updatePolicy": "never"
- }
- }
- ]
- plugin_repositories: >
- [
- {
- "id": "jboss-public-repository-group",
- "name": "JBoss Public Repository Group",
- "url":
"https://repository.jboss.org/nexus/content/groups/public";,
- "releases": {
- "enabled": "true",
- "updatePolicy": "never"
- },
- "snapshots": {
- "enabled": "${{ inputs.allow-snapshots }}",
- "updatePolicy": "never"
- }
- },
- {
- "id": "kogito-staging-repository-group",
- "name": "Kogito Staging Repositories",
- "url":
"https://repository.jboss.org/nexus/content/groups/kogito-public";,
- "releases": {
- "enabled": "true",
- "updatePolicy": "never"
- },
- "snapshots": {
- "enabled": "${{ inputs.allow-snapshots }}",
- "updatePolicy": "never"
- }
- }
- ]
- plugin_groups: >
- [
- "org.zanata"
- ]
+ shell: bash
+ run: |
+ cp maven-tools/.ci/actions/maven/settings-template.xml
${HOME}/.m2/settings.xml
Review Comment:
I think the custom settings.xml generation can be removed completely. Each
repository has the configuration of the repositories in their root pom, e.g.
here it is in kogito-runtimes
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/pom.xml#L75.
I think that way the deployment etc. can be controlled more easily, than in a
custom action like this. What do you think please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
