tkobayas commented on PR #5548:
URL:
https://github.com/apache/incubator-kie-drools/pull/5548#issuecomment-1756710773
Jenkins failures:
```
[ERROR]
org.kie.drl.engine.compilation.utils.DrlCompilerHelperTest.getDrlCallableClassesContainerFromFileResource
-- Time elapsed: 4.155 s <<< FAILURE!^M
java.lang.AssertionError: ^M
^M
Expected size: 45 but was: 49 in:^M
[ERROR]
org.kie.drl.engine.compilation.utils.DrlCompilerHelperTest.getDrlCallableClassesContainerFromPackageDescrResource
-- Time elapsed: 0.902 s <<< FAILURE!^M
java.lang.AssertionError: ^M
^M
Expected size: 45 but was: 49 in:^M
```
These tests checks the number of generated classes. This PR generates 4 more
classes (`LoanUnitQueryFindAllApplicationAmounts`, `LoanUnitQueryFindApproved`,
`LoanUnitQueryFindNotApprovedIdAndAmount` and
`LoanUnitQueryFindNotApprovedIdAndAmount$Result`), so I think you may just
change the assertion value, @mariofusco
```
diff --git
a/kie-drl/kie-drl-compilation-common/src/test/java/org/kie/drl/engine/compilation/utils/DrlCompilerHelperTest.java
b/kie-drl/kie-drl-compilation-common/src/test/java/org/kie/drl/engine/compilation/utils/DrlCompilerHelperTest.java
index 9c63d7f67d..88bfa9c424 100644
---
a/kie-drl/kie-drl-compilation-common/src/test/java/org/kie/drl/engine/compilation/utils/DrlCompilerHelperTest.java
+++
b/kie-drl/kie-drl-compilation-common/src/test/java/org/kie/drl/engine/compilation/utils/DrlCompilerHelperTest.java
@@ -90,7 +90,7 @@ class DrlCompilerHelperTest {
assertThat(retrieved.getModelLocalUriId().model()).isEqualTo("drl");
assertThat(retrieved.getModelLocalUriId().basePath()).isEqualTo(SLASH +
baseBath);
assertThat(retrieved.getFullClassNames()).hasSize(3); // magic
number due to compiled resources
- assertThat(retrieved.getCompiledClassesMap()).hasSize(45); // magic
number due to compiled resources
+ assertThat(retrieved.getCompiledClassesMap()).hasSize(49); // magic
number due to compiled resources
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
