tkobayas commented on code in PR #268:
URL:
https://github.com/apache/incubator-kie-benchmarks/pull/268#discussion_r1361735850
##########
drools-benchmarks-parent/drools-benchmarks-reliability/src/main/java/org/drools/benchmarks/reliability/AbstractReliabilityBenchmark.java:
##########
@@ -62,9 +66,19 @@ public String getInfinispanStorageMode() {
}
}
+ public enum Module {
+ INFINISPAN,
+ H2MVSTORE
+ }
Review Comment:
At first, I thought that `Module` is a good idea. But then we have to deal
with unexpected combinations like "H2MVSTORE" + "REMOTE", or "H2MVSTORE" +
"REMOTEPROTO".
If you run
```
java -jar target/drools-benchmarks-reliability.jar -jvmArgs "-Xms4g -Xmx4g"
-foe true -wi 0 -i 1 -f 1
org.drools.benchmarks.reliability.InsertAndFireBenchmark
```
You will hit a failure with such a combination.
Probably it's better to use only `Mode` as a benchmark parameter. You may
still use `Module` for internal code writing convenience (for example, `Mode`
can have `Module`). So add "H2MVSTORE" to Mode. Maybe also it's better to
rename like "EMBEDDED" to "INFINISPAN_EMBEDDED" and so on (but
`infinispanStorageMode` values shouldn't be changed , because it's used for
INFINISPAN_STORAGE_MODE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
