ricardozanini commented on code in PR #287: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/287#discussion_r1377756481
########## api/v1alpha08/sonataflowplatform_services_types.go: ########## @@ -0,0 +1,89 @@ +// Copyright 2023 Red Hat, Inc. and/or its affiliates +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package v1alpha08 + +// ServicesPlatformSpec describes the desired service configuration for "prod" workflows. +type ServicesPlatformSpec struct { + // Deploys the Data Index service for use by "prod" profile workflows. + // +optional + DataIndex *ServicesPodTemplateSpec `json:"dataIndex,omitempty"` + // Persists service(s) to a datasource of choice. Ephemeral by default. + // +optional + Persistence *PersistenceOptions `json:"persistence,omitempty"` +} + +// ServicesPodTemplateSpec describes the desired custom Kubernetes PodTemplate definition for the deployed flow. +// +// The FlowContainer describes the container where the actual service is running. It will override any default definitions. +// For example, to override the image one can use `.spec.services.dataIndex.container.image = my/image:tag`. +type ServicesPodTemplateSpec struct { + // Container is the Kubernetes container where the service should run. + // One can change this attribute in order to override the defaults provided by the operator. + // +optional + Container *FlowContainer `json:"container,omitempty"` + // Describes the PodSpec for the internal service deployment based on the default Kubernetes PodSpec API + // +optional + FlowPodSpec `json:",inline"` Review Comment: @tchughesiv replaying both comments, I think we can keep `PodSpec` and `ContainerSpec`. We are within the SonataFlow API module. I believe it's enough to differentiate from k8s API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
