mariofusco commented on code in PR #5665:
URL:
https://github.com/apache/incubator-kie-drools/pull/5665#discussion_r1466391166
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/PackageModel.java:
##########
@@ -233,10 +234,21 @@ public static void
initPackageModel(TypeDeclarationContext typeDeclarationContex
* @param packageName
* @return
*/
- public static String getPkgUUID(ReleaseId releaseId, String packageName) {
+ public static String getPkgUUID(KnowledgeBuilderConfigurationImpl
configuration, ReleaseId releaseId, String packageName) {
+ if (isReproducibleExecutableModelGeneration(configuration)) {
+ return StringUtils.getPkgUUID(releaseId != null ?
releaseId.toString() : "", packageName);
Review Comment:
In general for (nor reproducible) SNAPSHOTs we need a random UUID instead,
otherwise this breaks the incremental compilation when using a snapshot release
id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
