jordigilh commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1474466054
##########
controllers/platform/initialize.go:
##########
@@ -106,6 +107,13 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *operatorap
}
platform.Status.Version = metadata.SpecVersion
+ // store workflow persistence configuration
+ if platform.Spec.Persistence != nil {
+ persistence.WorkflowConfig.SetConfig(platform.Spec.Persistence)
Review Comment:
It's a cache for the platform persistence configuration that is retrieved by
the workflow's logic when configuring its persistence (either workflow or
fallback to the one in the platform in the same namespace).
> But what happens if we have two different platforms with different
persistence settings?
That's a good question!. Can we have 2 platform CRs in the same namespace?
If so, what should the logic do when that happens when their configuration
conflicts in terms of DI, JS and persistence configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
