tchughesiv opened a new pull request, #415:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/415
<!--
Welcome to the SonataFlow Operator! Before contributing, make sure to:
- Rebase your branch on the latest upstream main
- Link any relevant issues, PR's, or documentation
- Check that the commit message is concise and helpful:
- When fixing an issue, add "Closes #<ISSUE_NUMBER>"
- Follow the below checklist
-->
**Description of the change:**
This PR adds enabled supporting services to the `SonataFlow` status. With
this change, we'll start using the `SonataFlow.Status.Services` when generating
workflow properties ConfigMaps. This is to ensure `SonataFlow.Status.Services`
matches/dictates what is set in the managed application.properties ConfigMap.
This PR also ensures that supporting services changes, whether cluster-wide
or local to the workflow, are reflected via ConfigMap reconciliation... which
automatically triggers the workflow deployment to rollout and use the new
properties.
An example of the new status fields -
```yaml
apiVersion: sonataflow.org/v1alpha08
kind: SonataFlow
metadata:
name: workflow
namespace: <namespace>
spec:
...
status:
...
services:
dataIndexRef:
url: 'http://example-data-index-service.<namespace>'
jobServiceRef:
url: 'http://example-jobs-service.<namespace>'
```
**Motivation for the change:**
To reflect which supporting services are being used by each workflow so the
user has a clearer understanding.
To ensure supporting services settings/changes are reconciled to workflows
cluster-wide. This is critical. For example, we don't want workflows attempting
to communicate against services that have been disabled or deleted. The
workflows should always reflect the current state of the supporting services.
**Checklist**
- [ ] Add or Modify a unit test for your change
- [ ] Have you verified that tall the tests are passing?
<details>
<summary>
How to backport a pull request to a different branch?
</summary>
In order to automatically create a **backporting pull request** please add
one or more labels having the following format `backport-<branch-name>`, where
`<branch-name>` is the name of the branch where the pull request must be
backported to (e.g., `backport-7.67.x` to backport the original PR to the
`7.67.x` branch).
> **NOTE**: **backporting** is an action aiming to move a change (usually a
commit) from a branch (usually the main one) to another one, which is generally
referring to a still maintained release branch. Keeping it simple: it is about
to move a specific change or a set of them from one branch to another.
Once the original pull request is successfully merged, the automated action
will create one backporting pull request per each label (with the previous
format) that has been added.
If something goes wrong, the author will be notified and at this point a
manual backporting is needed.
> **NOTE**: this automated backporting is triggered whenever a pull request
on `main` branch is labeled or closed, but both conditions must be satisfied to
get the new PR created.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
