ljmotta commented on code in PR #2189:
URL:
https://github.com/apache/incubator-kie-tools/pull/2189#discussion_r1515394527
##########
packages/dmn-editor/env/index.js:
##########
@@ -23,14 +23,9 @@ module.exports =
composeEnv([require("@kie-tools/root-env/env")], {
vars: varsWithName({}),
get env() {
return {
- dmnEditor: {
- dev: {
- port: 3001,
- },
- },
dmnEditor: {
storybook: {
- port: 9901,
Review Comment:
The problem is happening because we use the STORYBOOK_BASE env variable
inside the storybook wrapper. We set the env variable on the start script and
them it's used inside the `storybook-base` bin, thus the terminal color. I
choose this approach as I had some problems evaluating the `build-env
boxedExpressionComponent.storybook.port` on Windows due to quotes and double
quotes. I guess I need to revist this problem. Anyway, this change should
affect only components that use storybook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
